darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-02 07:27:35 -04:00
Code Issues Packages Projects Releases Wiki Activity
4,270 Commits 57 Branches 61 Tags
33a2909a76198ca9fedc76c567779b08bbe86b0e
Commit Graph

4270 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
venusbb
33a2909a76 reverse code not seperating trial_mode_services 2017-10-02 14:26:08 +01:00
Chris Hill-Scott
7b12b7e03d Merge pull request #1513 from alphagov/add-letters-to-go-live 
Add letters to the request to go live page
 2017-10-02 10:53:08 +01:00
Leo Hemsted
cf3f4d5cee Merge pull request #1516 from alphagov/empty-inbound-sms 
make sure inbound sms page doesn't break if you receive a blank inbou…
 2017-09-29 13:51:30 +01:00
Leo Hemsted
bb44479b3e disable statsd when testing 
or it won't run if you're offline
 2017-09-29 10:16:20 +01:00
Leo Hemsted
57b4971ac1 update conftest and tests to contain accurate test data 
specifically, we identify inbound vs outbound by presence of
"notify_number", so ensure that test content actually contains that
field
 2017-09-29 10:15:17 +01:00
Chris Hill-Scott
77da7543c0 Merge pull request #1519 from alphagov/acas.org.uk 
Adding Acas.org.uk to whitelist
 2017-09-29 09:48:30 +01:00
Pete Herlihy
74992da1c8 Adding acas.org.uk to whitelist 2017-09-29 09:24:07 +01:00
Chris Hill-Scott
cc0e308076 Merge pull request #1518 from alphagov/quis-patch-1 
Update email-message.scss
 2017-09-28 16:15:58 +01:00
Chris Hill-Scott
26d1bda43c Update email-message.scss 
Got my first and last mixed up…
 2017-09-28 16:15:48 +01:00
Chris Hill-Scott
84a225ffdb Merge pull request #1517 from alphagov/right-padding-email-message 
Fix overridden padding on email subject
 2017-09-28 16:03:55 +01:00
Leo Hemsted
b1e809e82a make sure inbound sms page doesn't break if you receive a blank inbound message 2017-09-28 15:37:18 +01:00
Imdad Ahad
a273cfe951 Merge pull request #1511 from alphagov/imdad-katie-feat-make-add-letter-contact-validation 
Make the letter contact block (service settings form) compulsory
 2017-09-28 11:23:56 +01:00
Chris Hill-Scott
06caccdd26 Fix overridden padding on email subject 
Something in a new version of GOV.UK Elements, Template, or Frontend
Toolkit has introduced a rules which removes padding for the last
column in a table.

This is undesirable in the case of email message previews.
 2017-09-28 10:47:33 +01:00
Chris Hill-Scott
f9390b4fc5 Delete .gitattributes 2017-09-27 16:11:38 +01:00
Chris Hill-Scott
1037cb29c4 Merge pull request #1514 from alphagov/remove-package-lock 
Remove package-lock.json
 2017-09-27 16:11:16 +01:00
Chris Hill-Scott
d0a8cdecb0 Merge pull request #1515 from alphagov/pyup-update-pyexcel-0.5.3-to-0.5.4 
Update pyexcel to 0.5.4
 2017-09-27 16:05:57 +01:00
Chris Hill-Scott
f800cacf36 Merge pull request #1510 from alphagov/self-serve-international 
Allow services to turn international text messaging on and off
 2017-09-27 15:56:26 +01:00
pyup-bot
64f722e35f Update pyexcel from 0.5.3 to 0.5.4 2017-09-27 13:31:44 +01:00
Chris Hill-Scott
c11a15338c Remove package-lock.json 
I don’t think we’re getting any benefit from it. Especially since we’re
not running any Node code in production, but just using it to build the
frontend.

The downside is we keep getting these massive diffs which means we don’t
get an accurate line count on pull requests.

Followed instructions here:
https://codeburst.io/disabling-package-lock-json-6be662f5b97d
 2017-09-27 12:15:33 +01:00
Chris Hill-Scott
2f6cf3df38 Refactor permissions handling to use sets 
We didn’t like the nested conditional way of doing this. So this commit
refactors the way that permissions are set by:

- splitting it up into multiple, clearly named methods
- treating the list of permissions as `set`s, which they naturally are,
  because you can’t have duplicate permissions (this removes a lot of
  the complexity around having to test for membership before removing
  a permission, for example)
 2017-09-27 12:02:17 +01:00
Chris Hill-Scott
fb3e7b5fde Add letters to the request to go live page 
It’s not either text messages, or emails, or both now – it’s any
combination of the three channels.

This commit adds ‘letters’ as an option on the request to go live page
by changing the radio buttons to a group of checkboxes, so the user can
choose as many or as few as they want.

This commit also does a bunch of housekeeping stuff around the tests for
this page, because they haven’t been touched in quite some time.
 2017-09-27 10:46:52 +01:00
Imdad Ahad
fdabe814cc Make the letter contact block (service settings form) compulsory 2017-09-26 14:41:07 +01:00
Chris Hill-Scott
9581a3bb77 Allow services to turn international SMS on/off 
We didn’t make this self-service before because the pricing information
wasn’t published (ie we had to send it to services that asked for it).

Now that we publish pricing information in the app, there’s no reason
why services can’t make an informed decision about whether they want
international SMS or not.

So this commit:
- removes the platform admin button
- adds some radio buttons that our users can click with their mice
 2017-09-26 14:21:06 +01:00
Chris Hill-Scott
3906b31929 Optionally let client_request test for redirect 
A common pattern we employ is `POST`-redirect-`GET`. To write tests for
this we often check that the URL of the redirect is what we’re
expecting.

With the way `client_request` is currently set up, there’s no way to do
this because the response isn’t exposed to the test.

So this commit adds an extra parameter which will let us test for
redirects.
 2017-09-26 14:07:01 +01:00
Sakis
4b96e7ba1b Merge pull request #1505 from alphagov/configure-gunicorn-errorlog 
Configure gunicorn errorlog
 2017-09-26 11:01:48 +01:00
Chris Waszczuk
1dcfae41d1 Merge pull request #1509 from gov-cjwaszczuk/master 
Allow user to add multiple reply-to addresses
 2017-09-26 09:48:45 +01:00
Chris Hill-Scott
ab6e49ac6a Merge pull request #1508 from alphagov/default-notification-style 
Change text style of default banner
 2017-09-26 09:29:27 +01:00
Chris Hill-Scott
7797b670a9 Merge pull request #1507 from alphagov/pyup-update-whitenoise-3.3.0-to-3.3.1 
Update whitenoise to 3.3.1
 2017-09-26 09:29:22 +01:00
chrisw
f012ec57c0 Allow user to add multiple reply-to addresses 2017-09-25 17:05:41 +01:00
Athanasios Voutsadakis
1e9c04c583 Change .info to .error 2017-09-25 16:24:11 +01:00
Chris Hill-Scott
324cec90cd Merge pull request #1500 from alphagov/bump-govuk-packages 
Update versions of GOV.UK packages
 2017-09-25 15:27:52 +01:00
Chris Hill-Scott
48b49ebdd3 Update versions of GOV.UK packages 
GOV.UK elements:
- Changelog: https://github.com/alphagov/govuk_elements/blob/master/packages/govuk-elements-sass/CHANGELOG.md#311
- Full changes: https://github.com/alphagov/govuk_elements/compare/v3.0.3...v3.1.1

GOV.UK template:
- Changelog: https://github.com/alphagov/govuk_template/blob/master/CHANGELOG.md
- Full changes: https://github.com/alphagov/govuk_template/compare/v0.19.2...v0.22.3

GOV.UK frontend toolkit:
- Changelog: https://github.com/alphagov/govuk_frontend_toolkit/blob/master/CHANGELOG.md#701
- Full changes: https://github.com/alphagov/govuk_frontend_toolkit/compare/v5.2.0...v7.0.1
 2017-09-25 15:20:35 +01:00
Chris Hill-Scott
0b1a08deef Change text style of default banner 
The green text looks nicer than the black text.

The bold makes it stand out more.
 2017-09-25 15:09:26 +01:00
Venus Bailey
fe541b849b Merge pull request #1506 from alphagov/vb-platform-admin-admin 
Platform Admin timeout problem
 2017-09-25 13:24:01 +01:00
pyup-bot
298070d6c0 Update whitenoise from 3.3.0 to 3.3.1 2017-09-23 18:37:39 +01:00
venusbb
b0e267f677 Fixed tests 2017-09-22 23:09:44 +01:00
venusbb
0895717680 Merge branch 'master' of https://github.com/alphagov/notifications-admin into vb-platform-admin-admin 2017-09-22 15:47:19 +01:00
venusbb
3a1e76ba92 Progress: passed trial_mode to /service end point 2017-09-22 15:46:52 +01:00
Athanasios Voutsadakis
79752d2754 Configure gunicorn errorlog 
Related: alphagov/notifications-api/pull/1274
 2017-09-22 15:41:41 +01:00
Chris Hill-Scott
241e3c2232 Merge pull request #1504 from alphagov/77-78 
77-78 for Legal Aid Agency
 2017-09-21 15:28:41 +01:00
Pete Herlihy
033872c34e And now to 79 2017-09-21 15:10:42 +01:00
Chris Hill-Scott
7327f4b611 Merge pull request #1503 from alphagov/logoless-organisations 
Allow creation of an organisation without a logo
 2017-09-21 13:01:44 +01:00
Pete Herlihy
d5ff02e5f7 77-78 for Legal Aid Agency 2017-09-21 12:08:30 +01:00
Chris Hill-Scott
d01c397bb4 Allow creation of an organisation without a logo 
Now we have the org banner branding, not all organisations need a logo.
So it shouldn’t be an error to not provide one.

Depends on:
- [ ] https://github.com/alphagov/notifications-api/pull/1265
 2017-09-21 11:57:39 +01:00
Sakis
3628f7d7d3 Merge pull request #1489 from alphagov/bump_utils 
Bump utils to 21.2.0
 2017-09-21 10:57:05 +01:00
Chris Hill-Scott
9b663d0865 Merge pull request #1502 from alphagov/bbsrc 
Add Biotechnology and Biological Sciences Research Council to email domain list
 2017-09-21 10:21:51 +01:00
Leo Hemsted
a1a4a28955 Merge pull request #1501 from alphagov/accepted-letters-on-api 
show letters as accepted, not created or sending, on the api page
 2017-09-20 16:51:55 +01:00
Chris Hill-Scott
6d421a0424 Add Biotechnology and Biological Sciences Research Council to email domain list 
> BBSRC is an executive non-departmental public body, sponsored by the
> Department for Business, Energy & Industrial Strategy.

– https://www.gov.uk/government/organisations/biotechnology-biological-sciences-research-council
 2017-09-20 16:23:18 +01:00
Leo Hemsted
03397f416e move status mapping logic to the api client 
also added tests 👼
 2017-09-20 16:02:15 +01:00
Leo Hemsted
f8fab35ee7 show letters as accepted, not created or sending, on the api page 2017-09-20 14:38:15 +01:00