Commit Graph

7214 Commits

Author SHA1 Message Date
Tom Byers
2d85469cd0 Move 'Clear' link out of 'aria-hidden' region 2019-02-21 13:27:18 +00:00
Tom Byers
15104e9d25 Re-position live-region to remove duplication
Adding a visually hidden live-region creates
duplication in the HTML. End result for users of
screen readers are that you get the same text read
out twice.

This adds `aria-hidden` to hide the visible
version and re-positions the live-region one next
to it. That means the live-region text appears in
the same place in the document order as the
visible one so things are announced as expected.
2019-02-21 13:27:18 +00:00
Tom Byers
050a513cf5 Update a11y API when selection count changes
Inserts a hidden live region to ensure changes to
the count are announced.

The live region is hidden because it needs to be
in the initial markup of the page. The visual
counter is part of a larger region which is
inserted/removed from the DOM.

See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions
2019-02-21 13:26:14 +00:00
Tom Byers
a8cac953d7 Deal with lost focus when selection cleared
This was missed out of the work on improving focus
on the templates page.

When you clear the current selection, the 'clear'
link disappears so focus needs to be sent
somewhere.
2019-02-21 13:26:14 +00:00
Alexey Bezhan
60b69bc0b5 Merge pull request #2780 from alphagov/service-settings-table
Replace platform admin service setting buttons with forms
2019-02-21 10:57:46 +00:00
Alexey Bezhan
261d90ca4d Add edit_folder_permissions permission
Admin part of alphagov/notifications-api#2356
Adds Folder permissions switch to the platform admin part of service
settings page.
2019-02-20 16:45:12 +00:00
Alexey Bezhan
000d6c3a48 Replace platform admin service setting buttons with forms
Most of the existing platform admin buttons on the service settings
page used to issue GET requests to switch service settings. This
means they weren't protected by CSRF. On top of that as our number
of service permissions increases over time a lot of buttons on the
page made it hard to work with.

To fix these issues we replace most of the buttons with rows in the
platform admin settings table. Each setting has a 'Change' link that
leads to a page with an On/Off switch form.

This removes "research mode" switch completely since we're planning
to deprecate it in the future and we don't expect to switch any new
services into research mode at the moment.

Most service permissions are now handled by a shared endpoint that
is parameterized with the permission name. Some permissions that
require some additional logic before they can be toggled (like document
upload, which requires setting a contact address) have separate
initial endpoints that redirect to `set_service_permission`.

"Archive", "Suspend" and "Resume" actions are kept as buttons since
they display a confirmation banner (which is a CSRF-protected form)
and they're not easily represented as an On/Off switch.
2019-02-20 16:45:12 +00:00
Alexey Bezhan
75fd2d4ffc Add a new boolean radios fields and change forms to use it
This adds a new OnOffField class that implements a boolean field
that is rendered as two On / Off radio buttons. This allows us to
avoid comparing 'on' and 'off' string values in the views since
the field takes care of transforming form data into python booleans.

This also adds a form class that can be used for any single On / Off
switch forms (e.g. service permissions).
2019-02-20 16:45:12 +00:00
Chris Hill-Scott
ddbd4380c9 Merge pull request #2792 from alphagov/Fix-sticky-menu-content
Updated new template menu content
2019-02-20 16:02:39 +00:00
Chris Hill-Scott
fe57d0adc8 Fix tests 2019-02-20 15:54:00 +00:00
karlchillmaid
884734a1b2 Updated button content
Updated button content
2019-02-20 15:05:08 +00:00
karlchillmaid
03a2b28269 Corrected: Add to new folder button
Corrected: Add to new folder button
2019-02-20 14:58:14 +00:00
karlchillmaid
aaacf69fdc Updated new template menu content
Updated new template menu content to make it consistent with the `New template` button and `Copy an existing template` page
2019-02-20 14:39:40 +00:00
Chris Hill-Scott
308470af31 Merge pull request #2791 from alphagov/wiltshire.gov.uk
Mark agreement signed by Wiltshire
2019-02-20 13:43:00 +00:00
Chris Hill-Scott
d0c7895a0d Mark agreement signed by Wiltshire 2019-02-20 13:31:37 +00:00
Chris Hill-Scott
9616d0dc2d Merge pull request #2772 from alphagov/branding-spec
Add spec for email/letter branding
2019-02-20 11:30:20 +00:00
Chris Hill-Scott
1e4e149f03 Merge pull request #2788 from alphagov/northtyneside.gov.uk
Mark agreement signed by North Tyneside council
2019-02-20 10:32:01 +00:00
Chris Hill-Scott
25a7bb1ee0 Merge pull request #2790 from alphagov/request-letter-branding-for-edit
Let users who can edit templates request branding
2019-02-20 10:31:39 +00:00
Chris Hill-Scott
d3b8e3e4ea Let users who can edit templates request branding
Because they can see the button, but currently get a `403`…
2019-02-20 10:19:24 +00:00
Chris Hill-Scott
afb61bb038 Mark agreement signed by North Tyneside council 2019-02-19 16:49:08 +00:00
Leo Hemsted
c261c41475 Merge pull request #2769 from alphagov/delete-redis-button
Clear redis cache page
2019-02-19 16:20:55 +00:00
Katie Smith
2f4e933b65 Merge pull request #2773 from alphagov/letter-branding-preview
Add preview pane for letter branding
2019-02-19 14:05:21 +00:00
karlchillmaid
2659db4ad0 Merge pull request #2775 from alphagov/updated-message-statuses
Update message status descriptions to match the documentation.
2019-02-19 13:37:51 +00:00
Chris Hill-Scott
376bc9534c Merge pull request #2786 from alphagov/flag-dwp
Flag go live requests from DWP
2019-02-19 12:01:07 +00:00
Leo Hemsted
bfefb115ed move choices from form to view
so that when updating, you don't have to update two separate places
2019-02-19 11:35:34 +00:00
Chris Hill-Scott
032cbf9a17 Flag go live requests from DWP
It’s not enough to check that they’ve signed the agreement. We have to
make sure we inform them every time a service wants to go live.
2019-02-19 11:18:50 +00:00
Katie Smith
d904c7e5c5 Show letter branding preview when selecting a brand
This adds a preview pane which is visible when updating a letter brand.

If JavaScript is enabled, the preview pane shows on the set-letter-branding
page, and submitting the form saves updates the letter brand for a service
immediately. If Javascript is not enabled, there is a separate 'Preview email
branding' page which shows a preview of the brand and has a 'Save' button on it.
2019-02-19 10:44:51 +00:00
Katie Smith
44781e3b69 Change preview pane JS to preview letters as well as emails 2019-02-19 10:44:51 +00:00
Katie Smith
83c10149bd Rename 'email-branding-preview' CSS styles to 'branding-preview'
Renamed since the same styling will be used for previewing letters.
2019-02-19 10:44:51 +00:00
Chris Hill-Scott
8986e1db32 Merge pull request #2785 from alphagov/judicialappointments.digital
Adding judicialappointments.digital to the email domains
2019-02-19 10:35:50 +00:00
Pete Herlihy
a89ad81cdc Adding judicialappointments.digital to the email domains 2019-02-19 10:23:52 +00:00
Chris Hill-Scott
eeeaa5546e Merge pull request #2781 from alphagov/pyup-update-coveralls-1.5.1-to-1.6.0
Update coveralls to 1.6.0
2019-02-19 10:19:28 +00:00
Chris Hill-Scott
203393de23 Merge pull request #2783 from alphagov/pyup-update-flake8-3.7.5-to-3.7.6
Update flake8 to 3.7.6
2019-02-19 10:19:17 +00:00
Chris Hill-Scott
420b17cd49 Merge pull request #2784 from alphagov/torridge.gov.uk
Mark agreement signed by Torridge District Council
2019-02-19 10:19:01 +00:00
Chris Hill-Scott
f0af083892 Mark agreement signed by Torridge District Council 2019-02-19 10:12:09 +00:00
pyup-bot
7be7861473 Update flake8 from 3.7.5 to 3.7.6 2019-02-18 21:48:03 +00:00
pyup-bot
12ddd5c514 Update coveralls from 1.5.1 to 1.6.0 2019-02-18 18:57:55 +00:00
Chris Hill-Scott
86e6f4a843 Merge pull request #2779 from alphagov/oxford.gov.uk
Mark agreement signed by Oxford City Council
2019-02-18 16:14:50 +00:00
Chris Hill-Scott
877556c2d7 Mark agreement signed by Oxford City Council 2019-02-18 16:08:01 +00:00
karlchillmaid
d4516f3f4d Remove 'pending' status 2019-02-18 13:57:01 +00:00
Chris Hill-Scott
61b8e10fc0 Merge pull request #2765 from alphagov/folder-after-delete-template
Return to a template’s folder after deleting it
2019-02-18 13:22:27 +00:00
Chris Hill-Scott
782d705857 Merge pull request #2778 from alphagov/southwark
Added Southwark council agreement
2019-02-18 12:20:51 +00:00
Pete Herlihy
ffa5cb6a1c Added Southwark council agreement 2019-02-18 12:14:14 +00:00
Leo Hemsted
b062a5a13f make banner green (default) instead of red (dangerous) 2019-02-18 12:09:14 +00:00
Pea (Malgorzata Tyczynska)
cdbbdda730 Merge pull request #2771 from alphagov/update_passowrds_blacklist
Update common passwords blacklist
2019-02-18 11:02:40 +00:00
Chris Hill-Scott
d83622d3b4 Merge pull request #2777 from alphagov/antrim-and-newtonabbey-runneymede-east-riding-of-yorkshire
Mark agreement signed by 3 councils
2019-02-18 10:43:41 +00:00
Chris Hill-Scott
24ba4235d1 Mark agreement signed by 3 councils
- Antrim and Newtonabbey
- Runneymede
- East Riding of Yorkshire
2019-02-18 10:12:22 +00:00
karlchillmaid
9450787c95 Removed API statuses
Removed API statuses. Added a link to documentation.
2019-02-15 17:12:28 +00:00
karlchillmaid
f362cebd88 Correct headings 2019-02-15 16:59:41 +00:00
karlchillmaid
c3be75e7f7 Fix typo
Fix typo
2019-02-15 16:54:15 +00:00