darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-07 11:53:52 -05:00
Code Issues Packages Projects Releases Wiki Activity
10,506 Commits 52 Branches 59 Tags
27f7e873f1defb2d439deecb00a978c63def4106
Commit Graph

10506 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tom Byers
27f7e873f1 Merge pull request #3645 from alphagov/fix-focus-on-table 
Make only the scrollable table focusable
 2020-09-23 11:32:04 +01:00
Chris Hill-Scott
dcd48f99dd Merge pull request #3632 from alphagov/training-broadcast-approved 
Add a tour screen once a broadcast is approved
 2020-09-23 11:07:03 +01:00
Tom Byers
cf07d79024 Make difference between table frames obvious 
...by naming the attributes related to
accessibility.

Also includes tests for this.
 2020-09-23 10:33:58 +01:00
Tom Byers
041f061dec Make only the scrollable table focusable 
The JS clones the scrollable table so was passing
its attributes across to the fixed one (which
provides the row headings).

This bug was pushed in:

https://github.com/alphagov/notifications-admin/pull/3637
 2020-09-23 09:58:27 +01:00
Tom Byers
6ab85c4c78 Merge pull request #3637 from alphagov/make-table-focusable 
Make table focusable
 2020-09-23 09:36:17 +01:00
Tom Byers
a75cde039f Merge pull request #3624 from alphagov/add-accessible-letter-specification 
Add accessible letter specification
 2020-09-22 16:36:15 +01:00
karlchillmaid
f6a31dfcaf Update details link 2020-09-22 16:19:25 +01:00
Chris Hill-Scott
6047bd3520 Fix duplicated h2 2020-09-22 15:52:52 +01:00
Chris Hill-Scott
2d64306e88 Link to specification page, not PDF directly 2020-09-22 15:49:38 +01:00
Chris Hill-Scott
a384f4cace Add route for letter specification page 2020-09-22 15:36:20 +01:00
karlchillmaid
cab0a0723e Add details component 2020-09-22 14:57:10 +01:00
karlchillmaid
9e64eaaf83 Update content 2020-09-22 14:51:36 +01:00
karlchillmaid
4616349b16 Add note 2020-09-21 16:41:02 +01:00
karlchillmaid
e6f1caae88 Add link to letter specification page 2020-09-21 16:22:15 +01:00
karlchillmaid
10a93cdbdb Add punctuation 2020-09-21 16:11:15 +01:00
karlchillmaid
68c9486b1f Remove content from this page 
This content has moved to the new Letter specification page.

Will need to add the link to that page.
 2020-09-21 16:09:53 +01:00
karlchillmaid
ddb671457c Update page content 2020-09-21 16:08:02 +01:00
Leo Hemsted
422825f03b Merge pull request #3629 from alphagov/fix-broadcast-back-links 
fix back links for broadcast libraries
 2020-09-21 11:37:21 +01:00
Leo Hemsted
a6b25b5991 add back links 
previously the back link went to choosing a library.

Now, if you view a district from a county, go back to the county page.
Otherwise, go back to the top level of the library.
 2020-09-21 11:24:05 +01:00
Chris Hill-Scott
fec8dc8911 Adjust wording of first paragraph 
I’ve swapped the order of the first paragraph so it joins into one
sentence, and leads with ‘Notify has not broadcast your alert’ which
is the response to what the user has just done. I don’t think we need
to say ‘still’ because the idea is users will swap back and forth
between training and real depending on the situation.
 2020-09-21 10:53:39 +01:00
Chris Hill-Scott
5c22bd56ce Add a tour screen once a broadcast is approved 
For a training broadcast the user doesn’t get that immediate feedback
that something has happened, like they would with a real alert, or even
sending themselves a text message.

This commit adds another tour-style page which will interrupt their
journey and hopefully reinforce the message we’ve given them earlier in
the tour.

We’re adding this because we’ve found in research that users don’t have
a good grasp of the consequences and severity of emergency alerts,
versus regular text messages.
 2020-09-21 09:41:19 +01:00
Tom Byers
a9c1d64326 Add tests for the focus style & new attributes 2020-09-19 22:03:45 +01:00
Tom Byers
de89e3cc11 Make fullscreen focusable 
Includes:
- adding tabindex=0 to make it focusable
- giving it a focus style matching GOVUK Frontend
- giving it a label matching the table caption

Taken from this article:

https://adrianroselli.com/2017/11/a-responsive-accessible-table.html#ResponsiveScrollingKeyboard
 2020-09-19 22:03:45 +01:00
Katie Smith
7040c7bdd0 Merge pull request #3636 from alphagov/fix-status-display 
Fix the display of sms statuses
 2020-09-18 16:51:01 +01:00
Katie Smith
a67ea9a623 Fix the display of sms statuses 2020-09-18 16:26:08 +01:00
Tom Byers
dd9ab6f8cf Merge pull request #3635 from alphagov/make-selection-summary-more-detailed 
Make selection summary more detailed
 2020-09-18 14:20:56 +01:00
Tom Byers
4b28846c6b Make selection summary (counter) more detailed 2020-09-18 12:10:32 +01:00
Tom Byers
704de9ebf3 Add tests for various different counter states 2020-09-18 12:10:32 +01:00
Tom Byers
2f18e4b2f0 Update test helper that generates checkboxes 
It was using GOVUK Elements HTML and we have since
moved to GOVUK Frontend.
 2020-09-18 11:50:32 +01:00
Tom Byers
b19330ae1e Merge pull request #3634 from alphagov/add-announcements-to-live-search 
Add announcements to live search
 2020-09-18 11:31:06 +01:00
Tom Byers
43935457d8 Change live-search so it announces results 
If there is a search term when the page loads, a
statement about the results is added to the
searchbox label.

All subsequent searches are announced via an aria
live-region.
 2020-09-17 14:38:40 +01:00
Tom Byers
3719479356 Add tests for live-search announcements 2020-09-17 14:38:40 +01:00
Chris Hill-Scott
8806734f03 Merge pull request #3633 from alphagov/focus-area-remove 
Use new focus colour for remove area button
 2020-09-17 13:31:19 +01:00
karlchillmaid
60a63c69ee Merge pull request #3578 from alphagov/update-sent-status-label 
Update sent status label
 2020-09-17 13:16:41 +01:00
Chris Hill-Scott
23e6e30092 Use new focus colour for remove area button 
It already adds a black border on focus so doesn’t need the thick lower
border.
 2020-09-17 12:46:45 +01:00
Chris Hill-Scott
daaa3d69a3 Make sent international status display on 2 lines 
Otherwise it wraps awkwardly
 2020-09-17 12:33:46 +01:00
Chris Hill-Scott
dd8ce7d5bd Merge pull request #3631 from alphagov/delete-plot-areas 
Delete plot-areas.py
 2020-09-17 11:41:16 +01:00
Chris Hill-Scott
8a413bec91 Merge pull request #3617 from alphagov/population-estimates 
Give estimates of the number of phones in a broadcast area
 2020-09-17 11:41:00 +01:00
Chris Hill-Scott
4c7180ca75 Update tests/app/broadcast_areas/test_broadcast_area.py 
Co-authored-by: David McDonald <idavidmcdonald@me.com>
 2020-09-17 11:09:52 +01:00
Chris Hill-Scott
ae17ff1f07 Fix significant figure round for value of 0 
You can’t do `log10(0)` in maths, so we need to handle it as a special
case.
 2020-09-17 11:08:36 +01:00
Chris Hill-Scott
ba9f786971 Move round_to_significant_figures into utils 2020-09-17 11:03:14 +01:00
Chris Hill-Scott
76244d8c07 Handle areas with missing data 
At the moment there are some areas which have:
- a `count_of_phones` value of `None`
- no sub-areas

This is wrong, but until we fix the data the phone counting code needs
to handle this.

This commit:
- adds the `or 0` in the right place (where it will catch these areas
  with missing data)
- adds a test which checks these areas, and compares them to other kinds
  of areas
 2020-09-17 11:02:22 +01:00
Tom Byers
10280eb662 Merge pull request #3630 from alphagov/fix-copy-to-clipboard-selection 
Fix copy to clipboard selection
 2020-09-16 15:40:03 +01:00
Tom Byers
e6b13ab6aa Merge pull request #3628 from alphagov/update-focus-style-to-govuk-frontend-3-version 
Update focus style to GOVUK Frontend 3 version
 2020-09-16 14:55:30 +01:00
Chris Hill-Scott
e232950d46 Add tests for the population calculations 
Now that this function is split out we can unit test it to make sure
that the expected numbers are coming out of it.
 2020-09-16 14:45:54 +01:00
Chris Hill-Scott
49195cb0d3 Rename constants to populations 
This is a better name for the module because it’s:
- not just constants, there’s a method in here now
- only stuff to do with populations, not other kinds of constants
 2020-09-16 14:45:45 +01:00
Tom Byers
308f9980d3 Fixes for focus issues on /templates page(s) 
Includes:
- fixes for the cancel button, when selecting a
  template type (after clicking 'New template')
- making the folder icon black, to match the text,
  on template list items
 2020-09-16 14:43:48 +01:00
Tom Byers
b525015765 Bump styles for existing GOVUK Frontend radios 
We have some radios using the GOVUK Frontend
radios component in this app. They are version
2.x.x though so this bumps their styles to version
3.x.x to get the new focus style.
 2020-09-16 14:00:15 +01:00
Chris Hill-Scott
3047af2c13 Refactor to make testing easier 2020-09-16 11:33:57 +01:00
Chris Hill-Scott
b9f75218d1 Add tests to ensure all areas have a count 2020-09-16 11:20:22 +01:00