Commit Graph

10539 Commits

Author SHA1 Message Date
Pea Tyczynska
23497c839c Turn autofocus on for search in broadcast views
Accessibility audit uncovered issues screen-reader users would
have with autofocus on Notify pages. Autofocus can lead to
confusion for those types of users and make them miss parts
of the page.

Hence, we decided that autofocus will be turned off by default
for live-search component.

We decided to keep the autofocus on for live-search text box when:
1. the page is a task page - as opposed to browsing pages, where
user wonders freely, task pages have more established flow, so
page focusing on textbox can actually be helpful.
2. page does not have actionable elements above the autofocus.
2020-09-24 13:06:51 +01:00
Pea Tyczynska
d7637dcca4 Turn autofocus on for platform admin branding pages search boxes
Accessibility audit uncovered issues screen-reader users would
have with autofocus on Notify pages. Autofocus can lead to
confusion for those types of users and make them miss parts
of the page.

Hence, we decided that autofocus will be turned off by default
for live-search component.

We decided to keep the autofocus on for live-search text box when:
1. the page is a task page - as opposed to browsing pages, where
user wonders freely, task pages have more established flow, so
page focusing on textbox can actually be helpful.
2. page does not have actionable elements above the autofocus.
2020-09-24 13:04:53 +01:00
Pea Tyczynska
ad6dc670f1 Turn autofocus on for broadcast areas search box
Accessibility audit uncovered issues screen-reader users would
have with autofocus on Notify pages. Autofocus can lead to
confusion for those types of users and make them miss parts
of the page.

Hence, we decided that autofocus will be turned off by default
for live-search component.

We decided to keep the autofocus on for live-search text box when:
1. the page is a task page - as opposed to browsing pages, where
user wonders freely, task pages have more established flow, so
page focusing on textbox can actually be helpful.
2. page does not have actionable elements above the autofocus.
2020-09-24 12:55:30 +01:00
Pea Tyczynska
bd19b1171c Autofocus now optional for live_search
This change has been made because autofocus has been confusing
to users of screenreaders because they orient themselves by
what is in focus. Moving it when the page loads without warning
can cause confusion and mean they miss parts of the page
before the point focus has moved to.

So now we will only turn on autofocus if there are no other
elements in the page that need attention than the search box.
2020-09-24 12:27:10 +01:00
Chris Hill-Scott
fa54c0fec4 Merge pull request #3649 from alphagov/fix-training-styling-tour-5
Fix styling of ‘Training’ tag on tour step 5
2020-09-24 10:22:16 +01:00
Chris Hill-Scott
0482c62cb8 Fix styling of ‘Training’ tag on tour step 5
It was missing the base class so didn’t get all the styling (like the
spacing and uppercase text).

Already fixed this for step 6, but less haste, more speed.
2020-09-23 17:38:39 +01:00
Chris Hill-Scott
4f0347b26d Merge pull request #3646 from alphagov/remove-yellow
Replace uses of $yellow for focus
2020-09-23 16:32:14 +01:00
Chris Hill-Scott
c0be215068 Merge pull request #3648 from alphagov/fix-training-styling-tour-6
Fix styling of ‘Training’ tag on tour step 6
2020-09-23 16:22:02 +01:00
Chris Hill-Scott
59bf38e623 Fix styling of ‘Training’ tag on tour step 6
It was missing the base class so didn’t get all the styling (like the
spacing and uppercase text).
2020-09-23 16:03:05 +01:00
Chris Hill-Scott
cc456fa718 Merge pull request #3642 from alphagov/live-broadcast-tag
Show an indication that a broadcast service is live
2020-09-23 15:32:33 +01:00
Chris Hill-Scott
36dd974b7e Merge pull request #3647 from alphagov/local-colour
Don’t use $yellow to indicate local environment
2020-09-23 15:32:25 +01:00
Chris Hill-Scott
9becb2b817 Merge pull request #3641 from alphagov/area-suggestions
Suggest previously-used areas when adding new area
2020-09-23 15:00:21 +01:00
Tom Byers
cbb435b013 Merge pull request #3644 from alphagov/add-accessibility-statement
Add accessibility statement
2020-09-23 14:02:27 +01:00
Chris Hill-Scott
c8f0664bf7 Show an indication that a broadcast service is live
We want it to be very clear whether you’re in live or training mode
because:
- you may be switching back and forth between them
- doing something in live mode when you think you’re in training mode
  would have… consequences

By adding a label next to the service name you’ll will have some
indication, on every page, which mode you are in.

Style of the label is based on the ‘Tag’ component from the Design
System:
https://design-system.service.gov.uk/components/tag/#showing-multiple-statuses
2020-09-23 13:05:07 +01:00
David McDonald
fe93e42197 Merge pull request #3638 from alphagov/redis-key-change
Step 1 of renaming cache keys for templates
2020-09-23 12:19:13 +01:00
Tom Byers
27f7e873f1 Merge pull request #3645 from alphagov/fix-focus-on-table
Make only the scrollable table focusable
2020-09-23 11:32:04 +01:00
Tom Byers
fb112bd5f7 Fix typo in status page issue
Co-authored-by: Chris Hill-Scott <me@quis.cc>
2020-09-23 11:27:31 +01:00
Tom Byers
80c84f2f52 Make reference to status page a link
Co-authored-by: Chris Hill-Scott <me@quis.cc>
2020-09-23 11:26:57 +01:00
Tom Byers
5e18988a3b Remove issue related to CSV table focus 2020-09-23 11:10:37 +01:00
Tom Byers
eba78ebf89 Update preparation and review dates 2020-09-23 11:09:06 +01:00
Chris Hill-Scott
dcd48f99dd Merge pull request #3632 from alphagov/training-broadcast-approved
Add a tour screen once a broadcast is approved
2020-09-23 11:07:03 +01:00
Chris Hill-Scott
6f389d044e Don’t use $yellow to indicate local environment
It clashes with the new `$govuk-focus-colour` now. This commit changes
it to half way between `govuk-colour("dark-grey")` (`#505a5f`) and
`govuk-colour("mid-grey")` (`#b1b4b6`) from the Design System. Dark was
too dark and mid was too light.

It also adds a line of JS to let us easily switch the header to blue by
clicking on it, which is useful for taking screenshots etc.
2020-09-23 11:02:21 +01:00
Chris Hill-Scott
b20ba2349e Replace uses of $yellow for focus
There are a few places where we missed updating to the new focus styles
because they were using the `$yellow` SASS variable and not the
`$focus-colour` variable.

This commit updates them to the new colour, and where needed adds the
black lower border to match.
2020-09-23 10:50:43 +01:00
Tom Byers
cf07d79024 Make difference between table frames obvious
...by naming the attributes related to
accessibility.

Also includes tests for this.
2020-09-23 10:33:58 +01:00
Tom Byers
041f061dec Make only the scrollable table focusable
The JS clones the scrollable table so was passing
its attributes across to the fixed one (which
provides the row headings).

This bug was pushed in:

https://github.com/alphagov/notifications-admin/pull/3637
2020-09-23 09:58:27 +01:00
Tom Byers
798c6ebc48 Exclude new page from navigation 2020-09-23 09:53:12 +01:00
Tom Byers
6ab85c4c78 Merge pull request #3637 from alphagov/make-table-focusable
Make table focusable
2020-09-23 09:36:17 +01:00
Tom Byers
2ec053ca3d Tweaks to email issue descriptions 2020-09-22 21:45:13 +01:00
Tom Byers
2212d3a5e0 Tweaks to issues summary & list + reporting 2020-09-22 21:44:38 +01:00
karlchillmaid
cd61479a4f Update PDF information 2020-09-22 20:47:05 +01:00
karlchillmaid
6cfc62216e Update summary 2020-09-22 19:15:13 +01:00
karlchillmaid
bd592ff67b Add status page information 2020-09-22 19:14:09 +01:00
Chris Hill-Scott
f50ef84c0d Suggest previously-used areas when adding new area
If you’re adding another area to your broadcast it’s likely to be close
to one of the areas you’ve already added.

But we make you start by choosing a library, then you have to find the
local authority again from the long list. This is clunky, and it
interrupts the task the user is trying to complete.

We thought about redirecting you somewhere deep into the hierarchy,
perhaps by sending you to either:
- the parent of the last area you’d chosen
- the common ancestor of all the areas you’d chosen

This approach would however mean you’d need a way to navigate back up
the hierarchy if we’d dropped you in the wrong place. And we don’t have
a pattern for that at the moment.

So instead this commit adds some ‘shortcuts’ to the chose library page,
giving you a choice of all the parents of the areas you’ve currently
selected. In most cases this will be one (unitary authority) or two
(county and district) choices, but it will scale to adding areas from
multiple different authorities.

It does mean an extra click compared to the redirect approach, but this
is still fewer, easier clicks compared to now.

This meant a couple of under-the-hood changes:
- making `BroadcastArea`s hashable so it’s possible to do
  `set([BroadcastArea(…), BroadcastArea(…), BroadcastArea(…)])`
- making `BroadcastArea`s aware of which library they live in, so we can
  link to the correct _Choose area_ page
2020-09-22 17:33:04 +01:00
karlchillmaid
8343de1f26 Update introduction content 2020-09-22 17:12:08 +01:00
Tom Byers
300af7126e Updates to issues in various places 2020-09-22 16:53:33 +01:00
Tom Byers
a75cde039f Merge pull request #3624 from alphagov/add-accessible-letter-specification
Add accessible letter specification
2020-09-22 16:36:15 +01:00
karlchillmaid
f6a31dfcaf Update details link 2020-09-22 16:19:25 +01:00
Tom Byers
0e0f5dcc5d Add copy from the draft document 2020-09-22 16:18:00 +01:00
Chris Hill-Scott
6047bd3520 Fix duplicated h2 2020-09-22 15:52:52 +01:00
Chris Hill-Scott
2d64306e88 Link to specification page, not PDF directly 2020-09-22 15:49:38 +01:00
Chris Hill-Scott
a384f4cace Add route for letter specification page 2020-09-22 15:36:20 +01:00
karlchillmaid
cab0a0723e Add details component 2020-09-22 14:57:10 +01:00
karlchillmaid
9e64eaaf83 Update content 2020-09-22 14:51:36 +01:00
Tom Byers
5241ea3ef0 Add basic page for accessibility statement 2020-09-22 11:46:57 +01:00
karlchillmaid
4616349b16 Add note 2020-09-21 16:41:02 +01:00
karlchillmaid
e6f1caae88 Add link to letter specification page 2020-09-21 16:22:15 +01:00
karlchillmaid
10a93cdbdb Add punctuation 2020-09-21 16:11:15 +01:00
karlchillmaid
68c9486b1f Remove content from this page
This content has moved to the new Letter specification page.

Will need to add the link to that page.
2020-09-21 16:09:53 +01:00
karlchillmaid
ddb671457c Update page content 2020-09-21 16:08:02 +01:00
David McDonald
e3baa9ba35 Step 1 of renaming cache keys for templates
We want to change cache keys for templates and broadcasts to include
their service ID. So cache keys should change from
`template-{template_id}-versions` to
`service-{service_id}-template-{template_id}-versions`.

The first step of this which needs to be deployed as a change first is
to delete both keys when updating service templates (even if they key is
not yet set). This means that when we release code in the next PR to
start setting the new key, we won't run into a case where either the old
or the new key can remain set with stale data.
2020-09-21 14:04:10 +01:00