darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-11 13:54:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,509 Commits 50 Branches 59 Tags
20fa3d2ea8a6ea9fa11d97fdd4653fd7a6e4191e
Commit Graph

2509 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
20fa3d2ea8 Bump utils version 
Brings in:
- [x] https://github.com/alphagov/notifications-utils/pull/68
 2016-09-14 10:31:00 +01:00
imdadahad
69c16cb0e4 Merge pull request #936 from alphagov/fix-forgot-password-empty-user-issue 
Fix exception raised when a pending user attempts to complete 'forgotten password' flow
 2016-09-13 15:39:29 +01:00
Chris Hill-Scott
6bad0101c8 Merge pull request #939 from alphagov/platform-admin-reorg 
Reorganise list of services on platform admin page
 2016-09-13 12:06:14 +01:00
Chris Hill-Scott
9da8734455 Merge pull request #935 from alphagov/fix-overlapping-on-notification-tables 
Fix overlapping text on tables of notifications
 2016-09-13 12:06:01 +01:00
Chris Hill-Scott
311ae4cfa4 Sort services by newest created first 
Other than which services are live it’s also interesting to know what
services are getting created on Notify. So let’s put the newest ones at
the top of the page.
 2016-09-13 10:38:33 +01:00
Chris Hill-Scott
88fff50ea3 Split platform admin page into live and trial mode 
It sucks having to scroll down the massive list of services just to see
which ones are live.
 2016-09-13 10:38:33 +01:00
Chris Hill-Scott
29d5bc4f51 Factor services table into a macro 
Since we’re going to have spearate tables for live and trial mode
services it saves copying and pasting to have a macro for them. Not
worth completely factoring out into a component because it’s only going
to be used on this page.
 2016-09-13 10:38:33 +01:00
Chris Hill-Scott
2156085813 Fix right aligned table headings 
The CSS for these wasn’t being set on the correct class.
 2016-09-13 10:38:33 +01:00
Chris Hill-Scott
e9d230b9a4 Always show created time for sending state 
When a notification is in `created` or `sending` the thing you care
about is how long it’s been sitting there.
 2016-09-13 10:37:38 +01:00
Chris Hill-Scott
6c961cc792 Remove date table field type 
No longer used anywhere.
 2016-09-13 10:37:38 +01:00
Chris Hill-Scott
95506e7c3b Refactor notification status into its own field type 2016-09-13 10:37:38 +01:00
Chris Hill-Scott
17d5af1a6e Show delivery time even for failed notifications 
We reckon it’s probably still useful.
 2016-09-13 10:37:38 +01:00
Chris Hill-Scott
2d7ed4d34f Fix overlapping text on tables of notifications 
This commit changes the tables of notifications from 3 columns to two
columns. This is so the text has more room, so it doesn’t start
overlapping.

It also makes sure that if the recipient gets really long that it will
be cut off with an ellipsis, rather than overlapping…

I hypothesize that if a notification fails you probably don’t care when
it failed, just that it failed.
 2016-09-13 10:37:38 +01:00
Andras Ferencz-Szabo
963decc205 Merge pull request #940 from alphagov/custom_error_pages 
Add custom static error pages for 413 and some 5xx errors
 2016-09-12 17:14:07 +01:00
bandesz
d11c7e08c2 Add final error page texts 2016-09-12 16:49:52 +01:00
bandesz
15fd390432 Add custom static error pages for 413 and some 5xx errors 2016-09-12 16:11:34 +01:00
Chris Hill-Scott
bee9043a4b Merge pull request #937 from alphagov/id-in-table 
Show notification ID in notification table
 2016-09-12 15:39:21 +01:00
Chris Hill-Scott
98dae76a8e Merge pull request #934 from alphagov/update-api-client 
Update Python client
 2016-09-12 15:39:14 +01:00
Chris Hill-Scott
92aacc1a54 Remove extraneous arguments to super 
> dont need self.__class__, self in super - that's a python 2.x crutch.
> super() is equivalent
 2016-09-12 14:59:53 +01:00
Chris Hill-Scott
5fda35c89d Make it clear that client do not use __init__ 
The clients never get passed useful values to their `__init__` methods.
Rather the real values are passed through later using the `init_app`
method.

So it should be an error if the client is relying on the values that
get passed to it’s init method. Easiest way to ensure this is by making
the `__init__` method not expect any arguments and passing fake values
to the `Super` call.
 2016-09-12 12:18:19 +01:00
Leo Hemsted
62868bc014 add test for id appearing in notification table 
use new pytest yield fixture
 2016-09-09 16:30:07 +01:00
Leo Hemsted
c47ce9b26f bump test requirements to most recent 2016-09-09 16:29:30 +01:00
Leo Hemsted
816ba32b25 add id field containg obj id to table if available 
useful for finding out a notification ID when investigating support issues
 2016-09-09 15:50:55 +01:00
Leo Hemsted
30d0944ca1 remove unused notification.html template 2016-09-09 15:50:14 +01:00
Imdad Ahad
defa7ac2c8 Remove spacing 2016-09-09 15:24:56 +01:00
Imdad Ahad
9eab8a726f - Add test to check that two-factor auth activates a user as expected 
- Ensure DB user activation statusupdate only executed when required
- Fix test_should_activate_user_after_verify
 2016-09-09 15:22:56 +01:00
Imdad Ahad
171eec5984 Remove pdb breaks 2016-09-08 16:59:32 +01:00
Imdad Ahad
65072e41d3 Fix issue where exception thrown when user does not activate email but successfully completes forgotten-password flow (which includes 2f) 2016-09-08 16:57:06 +01:00
Chris Hill-Scott
fa5e5475e9 Update Python client 
Just so that nobody else has to do it.

Implements:
- [x] https://github.com/alphagov/notifications-python-client/pull/29

Which is a breaking change requiring the renaming of method arguments.
 2016-09-08 15:55:07 +01:00
minglis
2ea401213e Merge pull request #928 from alphagov/rationalise-configs 
Simplified the config files for admin.
 2016-09-08 10:27:45 +01:00
Chris Hill-Scott
d46bfaba14 Merge pull request #933 from alphagov/revert-only-show-link-with-permissions 
Revert "Only show ‘Request to go live’ link to admin users"
 2016-09-08 09:49:21 +01:00
Chris Hill-Scott
e29952c4da Revert "Only show ‘Request to go live’ link to admin users" 
This reverts commit 385221cf5b.

The `current_user.has_permissions()` doesn’t seem to work on non-service
pages. Will investigate later.
 2016-09-08 09:46:31 +01:00
Chris Hill-Scott
5176590faf Merge pull request #932 from alphagov/visual-tidy-up 
Visual tidy up
 2016-09-08 09:31:36 +01:00
Martyn Inglis
130698f720 Removed unused route and fixed some formatting 2016-09-08 09:29:08 +01:00
imdadahad
cfbccab1e1 Merge pull request #925 from alphagov/update-readme 
Update README to include additional installation instructions
 2016-09-07 16:05:38 +01:00
Chris Hill-Scott
bafbeac8e6 Merge pull request #930 from alphagov/fix-display-of-jobs-on-dashboard 
Fix empty jobs table showing on dashbord
 2016-09-07 15:25:41 +01:00
Chris Hill-Scott
6f1fa62714 Merge pull request #927 from alphagov/quis-patch-1 
Reword resend email page
 2016-09-07 15:25:33 +01:00
Chris Hill-Scott
ac6b7dd0a0 Tweak spacing on API keys page 
Splits the clients section out a bit more clearly.
 2016-09-07 15:24:15 +01:00
Chris Hill-Scott
bdf5bd51b6 Remove 2/3rds and 3/4 columns 
These columns make the line length too short, and the text less
readable.
 2016-09-07 15:16:52 +01:00
Chris Hill-Scott
93a1f194e9 Remove ‘active’ title on team page 
This section of the page is covered by the ‘Team members’ `<h1>`.

Only the invited users is a special case that needs its own title.
 2016-09-07 15:16:02 +01:00
Chris Hill-Scott
385221cf5b Only show ‘Request to go live’ link to admin users 
Only users with the manage service permission can access this page, so
we should only show the link to users that have this permission.
 2016-09-07 15:14:48 +01:00
Chris Hill-Scott
9cf3854ac6 Merge pull request #929 from alphagov/fix-trial-mode-500 
Fix 500 on trial mode page
 2016-09-07 15:01:49 +01:00
Pete Herlihy
8a714a4e77 Merge pull request #931 from alphagov/dclg-email-domain 
Added dclg ticketing system domain to whitelist for return email
 2016-09-07 14:53:45 +01:00
Pete Herlihy
a7786c1e0b Added dclg ticketing system domain to whitelist for return email 2016-09-07 14:28:49 +01:00
imdadahad
be60e74a21 Merge pull request #926 from alphagov/add-redirect-for-email-verification 
Redirect and resend verification email when pending user attempts to login
 2016-09-07 14:23:56 +01:00
Chris Hill-Scott
9fa99fe007 Fix empty jobs table showing on dashbord 
If you have scheduled and then cancelled jobs this would be enough to
show the jobs block on the dashboard (in otherwords it wasn’t filtering
out cancelled jobs). However the contents of the table _were_ filtering
out cancelled jobs, so the table would be empty and look broken.

This commit changes the conditional to operate on the `list` of jobs
with cancelled ones filtered out.
 2016-09-07 11:13:07 +01:00
Chris Hill-Scott
743377f6b7 Fix 500 on trial mode page 
I was using the trial mode page to prototype the time picker as part of
225a61ddd3.

I didn’t clean up properly, and left an errant undefined variable, which
caused the trial mode page to `500`.

This commit:
- removes the errant argument
- adds a test for all the static pages to make sure that they at least
  return a `200`
 2016-09-07 10:49:57 +01:00
Martyn Inglis
42b04f0565 Merge branch 'master' into rationalise-configs 
Conflicts:
	app/main/views/jobs.py
 2016-09-07 10:34:53 +01:00
Martyn Inglis
b249477953 Simplified the config files for admin. 2016-09-07 10:31:33 +01:00
Chris Hill-Scott
897b89ba6e Make missed content changes on password sent page 
Lose the ‘now‘ like in: https://github.com/alphagov/notifications-admin/pull/877

Lose the ‘we‘ like in: https://github.com/alphagov/notifications-admin/pull/884
 2016-09-06 17:22:27 +01:00