Chris Hill-Scott
7324b30dbc
Re-add a 'requested' stat to a job
...
It’s useful to know how many notifications we’ve handed off to our
providers. This is a measure of how complete the processing of the job
is.
This is important, because once the job processing is complete then you
can accurately reconcile the report with the CSV file that you’ve
uploaded.
2016-08-30 14:57:28 +01:00
Martyn Inglis
fc3af8b56e
Extra test for the zero stats case
2016-08-26 15:27:04 +01:00
Martyn Inglis
8c159da3ea
Fix for admin app to show job data on dashboard page
...
- uses the new stats block in the API to build the stats expected by the dashboard page
- all work done in client
2016-08-26 15:21:10 +01:00
Martyn Inglis
fb9b33e3de
Removed check on notifications-sent, that was used to check whether it was old or new style API.
...
Now new style is deployed it's not needed.
Tests updated to reflect this,
2016-08-25 12:54:23 +01:00
Martyn Inglis
9b348880ef
Test for old style stats - make sure we don't override / fail if no new block present.
2016-08-24 10:42:57 +01:00
Martyn Inglis
5b2ae43d5d
Wrote some tests around the stats conversions.
...
Properly named the finished parameter.
Handled the root JSON key
2016-08-24 10:35:04 +01:00
Chris Hill-Scott
da1fa2e61c
Make _attach_current_user a pure function
...
Mutating dictionaries is gross and doesn’t work as you’d expect. Better
to have the function return a new dictionary instead.
Means we can be explicit that `created_by` is one of the allowed params
when updating a service.
2016-08-11 17:07:55 +01:00
Chris Hill-Scott
0cfe10639a
Only allow update service to modify named attrs
...
To prevent typos and inadvertently updating something we shouldn’t,
this adds some filtering to the update_service method to make sure it
is only allowed to update certain attributes of a service.
2016-08-11 17:07:43 +01:00
Leo Hemsted
f642d6a6f1
rename test variables for clarity
2016-08-10 15:55:13 +01:00
Leo Hemsted
e2875ea66e
Merge branch 'master' into remove-stats-from-send
2016-07-29 11:08:42 +01:00
minglis
817a52781f
Merge pull request #803 from alphagov/remove-stats-from-job-page
...
Remove stats from job page
2016-07-26 11:24:00 +01:00
Leo Hemsted
eaf9b6dc54
pass 'today_only' flag to the back-end from send page
...
also bump notification-utils requirement to 8.7.0 for changes
to RecipientCSV
2016-07-25 15:26:43 +01:00
Leo Hemsted
45debe0d5b
remove get_statistics_for_service_for_day from codebase
...
two down, three to go
2016-07-25 14:54:58 +01:00
Leo Hemsted
6ff77c995e
add tests for service_api_client
2016-07-21 17:32:28 +01:00
Leo Hemsted
57e03349d2
remove get_statistics_for_service from statistics_api_client
2016-07-20 15:54:30 +01:00
Leo Hemsted
5bd90bba64
make test folder structure align with app folder structure
2016-07-15 15:23:40 +01:00
Leo Hemsted
1cd2841c17
rename api_client to service_api_client
2016-07-15 15:23:23 +01:00
Leo Hemsted
2f1a807be3
delete template button POSTs archived:true
2016-05-23 15:04:24 +01:00
