darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-16 03:10:16 -04:00
Code Issues Packages Projects Releases Wiki Activity
6,177 Commits 60 Branches 61 Tags
0591d3e66778f3feaa2b7b0e278874e197f44334
Commit Graph

6177 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rebecca Law
0591d3e667 Merge pull request #2334 from alphagov/fix-download-bug 
Fix download csv to use the service data retention if it exists.
 2018-09-27 16:07:17 +01:00
Rebecca Law
7b9df8de29 Fix download csv to use the service data retention if it exists. 2018-09-27 14:51:36 +01:00
Tom Byers
5c143b6ec3 Merge pull request #2331 from alphagov/bump-utils 
Bump utils to 30.3.1
 2018-09-27 14:39:43 +01:00
Chris Hill-Scott
6de0374492 Merge pull request #2327 from alphagov/add-mou-to-checklist 
Add line about the data sharing and financial agreement to the checklist
 2018-09-26 16:33:13 +01:00
Chris Hill-Scott
0ff6d43396 Merge pull request #2330 from alphagov/pyup-update-pytest-xdist-1.23.0-to-1.23.1 
Update pytest-xdist to 1.23.1
 2018-09-26 16:17:07 +01:00
Chris Hill-Scott
edfd7531c9 Merge pull request #2332 from alphagov/dwp.gov.uk 
Mark agreement signed by DWP
 2018-09-26 16:16:58 +01:00
Chris Hill-Scott
c251c1326e Remove ‘Download the’ call to action 
Users come to this page from various places, including the new 'Sign
the…' link on the request to go live page.

Of these users:
- some won't have signed it
- some will have signed it
- some will see that it's complete and wonder why, as they haven’t
  actually done anything

So it’s more appropriate for the title of this page to be descriptive,
rather than an action.
 2018-09-26 16:14:50 +01:00
Chris Hill-Scott
2fe1a60bbf Mark agreement signed by DWP 2018-09-26 11:54:02 +01:00
Chris Hill-Scott
3fa877bdd3 Make wording around agreement more straightforward 
We think that the next page explains the nuance around service vs
organisation sufficiently well.
 2018-09-26 10:37:30 +01:00
pyup-bot
0bd15aa50d Update pytest-xdist from 1.23.0 to 1.23.1 2018-09-25 20:50:16 +01:00
Tom Byers
943a400c72 Bump utils to 30.3.1 
Brings in stripping of the line separator
character from emails.

https://github.com/alphagov/notifications-utils/pull/531
 2018-09-25 16:30:29 +01:00
Pea (Malgorzata Tyczynska)
6d32d8b756 Merge pull request #2324 from alphagov/state_postage 
Display postage on letter notification page
 2018-09-25 13:36:34 +01:00
Chris Hill-Scott
faee3b61dd Merge pull request #2328 from alphagov/pyup-update-notifications-python-client-5.1.0-to-5.2.0 
Update notifications-python-client to 5.2.0
 2018-09-25 12:51:10 +01:00
Chris Hill-Scott
9e91e55d88 Freeze requirements 2018-09-25 12:21:13 +01:00
pyup-bot
162b33e041 Update notifications-python-client from 5.1.0 to 5.2.0 2018-09-25 12:13:16 +01:00
Pea Tyczynska
d982385042 Change wording following content review 2018-09-25 11:05:32 +01:00
Chris Hill-Scott
5dd45da08c Add line about MOU to checklist 
2/3 of our incomplete requests to go live are incomplete because the
Data Sharing and Financial Agreement isn’t signed.

We reckon we can be pushier about this by saying it’s ‘incomplete’ where
we know the agreement is signed.

Where the agreement is signed we should confirm this, rather than make
the line disappear. This is so it makes more sense to someone who sees
it as ‘incomplete’, signs it, then comes back to the page.

If we don’t know whether or not the agreement is signed we should wait
until someone has got in touch with us by requesting to go live to
figure it out. So that’s why we’re not showing that line at all.
 2018-09-25 10:33:50 +01:00
Chris Hill-Scott
c2ef522986 Make task list read better for screen readers 
This duplicates how the task list pattern is coded in the GOV.UK
Prototype kit[1]. It adds ARIA attributes and the use of a
semantically-meaningful element (`<strong>`) to give more information to
screen reader users.

1. https://govuk-prototype-kit.herokuapp.com/docs/templates/task-list
 2018-09-25 10:31:40 +01:00
Chris Hill-Scott
d4b481d55e Merge pull request #2326 from alphagov/fix-missing-complete-tag-rtgl 
Fix missing ‘complete’ tag in go live request
 2018-09-25 09:48:58 +01:00
Chris Hill-Scott
21d29a3090 Fix missing ‘complete’ tag in go live request 
This tag was not showing up in the call to the Zendesk API because the
return value of a generator is not included as a member of that
generator (on things `yield`ed from it are).
 2018-09-24 17:47:56 +01:00
Chris Hill-Scott
8e48b17a6e Merge pull request #2321 from alphagov/auto-tag-request-to-go-live 
Tag request to go live tickets automatically
 2018-09-24 17:13:52 +01:00
Chris Hill-Scott
041ef27f99 Merge pull request #2325 from alphagov/teignbridge.gov.uk 
Mark agreement signed by Teignbridge council
 2018-09-24 16:47:34 +01:00
Chris Hill-Scott
34968fb5da Mark agreement signed by Teignbridge council 2018-09-24 16:26:17 +01:00
Chris Hill-Scott
073aaa0db7 Freeze requirements 2018-09-24 14:54:35 +01:00
Chris Hill-Scott
8bb23e09f2 Refactor to reduce nesting and repetition 2018-09-24 14:52:32 +01:00
Chris Hill-Scott
f29cfc0d48 Auto-tag email branding requests 2018-09-24 14:52:31 +01:00
Chris Hill-Scott
de65c30624 Tag request to go live tickets automatically 
At the moment we manually tag tickets as they come in so we can analyse
how many of each type we’re getting.

Further, we manually tag all the request to go live tickets once a month
to analyse how many are complete/incomplete.

All this tagging is useful, but quite time consuming. Notify already
knows this information and – using the Zendesk API – we can tag them
automatically.

I’ve checked with Holly and this is the taxonomy we want to use.
 2018-09-24 14:52:31 +01:00
Chris Hill-Scott
6990128212 Bump utils to 30.3.0 
Depends on:
- [ ] https://github.com/alphagov/notifications-utils/pull/529
 2018-09-24 14:52:31 +01:00
Chris Hill-Scott
f29c6c90c0 Add info about checklist to ticket 
So that someone picking up a ticket can be warned that they should be
checking these things.
 2018-09-24 14:52:31 +01:00
Chris Hill-Scott
45b1b11abb Refactor go-live readyness into service model 
All this info is info about the service. So it’s better to put it on
the service model because:
- encapsulation
- later reuse
 2018-09-24 14:52:30 +01:00
Chris Hill-Scott
d753e8351c Merge pull request #2318 from alphagov/pyup-update-whitenoise-4.0-to-4.1 
Update whitenoise to 4.1
 2018-09-24 13:50:00 +01:00
Chris Hill-Scott
80d33b9855 Freeze requirements 2018-09-24 13:31:56 +01:00
pyup-bot
7fb42c0877 Update whitenoise from 4.0 to 4.1 2018-09-24 13:30:14 +01:00
Chris Hill-Scott
9ff4138b12 Merge pull request #2323 from alphagov/pyup-update-pytest-3.8.0-to-3.8.1 
Update pytest to 3.8.1
 2018-09-24 13:29:34 +01:00
Pea Tyczynska
47d047a3a8 Add postage to fixtures and test postage display on notification page 2018-09-24 11:53:40 +01:00
Pea Tyczynska
64f356d7b0 Display postage on letter notification page 2018-09-24 11:29:33 +01:00
pyup-bot
ba0ba29907 Update pytest from 3.8.0 to 3.8.1 2018-09-22 21:50:08 +01:00
Katie Smith
e28ed2975b Merge pull request #2322 from alphagov/fix-settings-page-letters 
Hide Postage setting when letters are not enabled for service
 2018-09-21 08:52:30 +01:00
Katie Smith
fee47aa348 Hide Postage setting when letters are not enabled for service 
We don't show the sender addresses and letter branding on the settings page
if a service doesn't have letters enabled, so we should also hide the
postage for services that can't send letters.

(Postage can only be seen by Platform Admin users at the moment, but this will
change later).
 2018-09-20 15:46:32 +01:00
Chris Hill-Scott
cf553af4bf Merge pull request #2320 from alphagov/kingston.gov.uk 
Mark agreement signed by Kingston Council
 2018-09-20 15:31:40 +01:00
Chris Hill-Scott
ae2f6f14fa Mark agreement signed by Kingston Council 2018-09-20 11:20:46 +01:00
Katie Smith
7aedc3a91d Merge pull request #2311 from alphagov/show-postage-class 
Add letter class row to settings page, visible to platform admin only
 2018-09-20 09:52:24 +01:00
Katie Smith
3815a04a6f Merge pull request #2308 from alphagov/quis-patch-1 
Remove unused variable
 2018-09-20 09:52:18 +01:00
Katie Smith
623650b341 Merge pull request #2319 from alphagov/dbs.gov.uk 
Add owner to DBS domain
 2018-09-20 09:52:11 +01:00
Chris Hill-Scott
d011742593 Add owner to DBS domain 
All domains should have an owner
 2018-09-20 09:45:20 +01:00
Chris Hill-Scott
4ce82be8dd Merge pull request #2317 from alphagov/merthyr.gov.uk 
Mark agreement signed by Merthyr Tydfil
 2018-09-19 16:57:35 +01:00
Chris Hill-Scott
2b8da4a2fa Merge pull request #2315 from alphagov/3-becomes-4 
Set min text message sender length to 4 characters
 2018-09-19 16:57:27 +01:00
Katie Smith
2726467fc7 Minor quote and heading fixes 2018-09-19 16:53:31 +01:00
Chris Hill-Scott
2f298783e0 Mark agreement signed by Merthyr Tydfil 2018-09-19 16:45:05 +01:00
Chris Hill-Scott
0edc569247 Merge pull request #2316 from alphagov/warwickshire.gov.uk 
Mark agreement signed by Warwickshire County Council
 2018-09-19 16:33:29 +01:00