darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-21 05:32:44 -04:00
Code Issues Packages Projects Releases Wiki Activity
7,052 Commits 57 Branches 61 Tags
02ff79d0dd14df2ee528cd15d44ae9ae7998c46e
Commit Graph

7052 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Pea (Malgorzata Tyczynska)
02ff79d0dd Merge pull request #2733 from alphagov/postage_changes_before_it_goes_public 
People who can't send messages still see template postage class
 2019-02-05 16:52:21 +00:00
Chris Hill-Scott
0fc4245b16 Merge pull request #2732 from alphagov/resend-wording 
Refine wording of ‘already sent’ error
 2019-02-05 15:19:24 +00:00
Chris Hill-Scott
d9e3a90123 Remove ‘You’ve’ 
It could be someone else who’s uploaded them.
 2019-02-05 15:09:24 +00:00
Chris Hill-Scott
5a70587fe8 Refine wording of ‘already sent’ error 2019-02-05 14:59:21 +00:00
Chris Hill-Scott
27217f1ad1 Merge pull request #2731 from alphagov/fix-empty-message 
Fix empty folder message
 2019-02-05 14:55:26 +00:00
Chris Hill-Scott
ce04c9c45a Merge pull request #2725 from alphagov/job-sent-already 
Warn if a file has been sent already
 2019-02-05 14:55:08 +00:00
Chris Hill-Scott
975dce9f43 Merge pull request #2730 from alphagov/fix-hover-icon-ie10 
Fix hover folder icon in IE10/11
 2019-02-05 14:55:01 +00:00
Chris Hill-Scott
34f509af11 Fix empty folder message 
Sometimes, when filtering the view by template type, the message was
saying the folder was empty, when really it should have been saying that
there were no templates of the ‘type’ you’re looking for, eg:
> There are no email templates in this folder

This was because it was looking at the filtered list of templates, not
all templates to determine whether a folder was really empty.
 2019-02-05 14:28:11 +00:00
Chris Hill-Scott
e0d28cf1dd Fix hover folder icon in IE10/11 
Duplicates e0ecc95ac6

Copies the code from the normal folder icon, and manually tweaks the
colour, to also get the benefits of minification.

***

IE 10 supports using SVG[1] but has some buggy behaviour when they’re
used as background images.

Without an explicit width/height it stretches the viewBox of the SVG to
fill the containing element. This causes the content of the file to
display centered within the viewBox.

Explicitly setting the width and height seems to be the thing that fixes
this. Out of the suggested fixes on Stackoverflow[2] this one seems to
be the most straightforward.

1. https://caniuse.com/#feat=svg
2. https://stackoverflow.com/questions/17944354/svg-background-image-position-is-always-centered-in-internet-explorer-despite-b
 2019-02-05 13:50:39 +00:00
Chris Hill-Scott
311d615356 Merge pull request #2724 from alphagov/pyup-update-pytest-mock-1.10.0-to-1.10.1 
Update pytest-mock to 1.10.1
 2019-02-04 17:35:06 +00:00
Chris Hill-Scott
6be27459cd Merge pull request #2729 from alphagov/pyup-update-flake8-3.7.4-to-3.7.5 
Update flake8 to 3.7.5
 2019-02-04 17:34:59 +00:00
pyup-bot
9ae5a7c9ad Update flake8 from 3.7.4 to 3.7.5 2019-02-04 16:55:21 +00:00
Chris Hill-Scott
dc4668b51d Merge pull request #2722 from alphagov/southtyneside.gov.uk 
Mark agreement signed by South Tyneside
 2019-02-04 16:25:19 +00:00
Pea Tyczynska
2861a74d61 People who cant send messages see template postage class 2019-02-04 16:24:28 +00:00
Pea (Malgorzata Tyczynska)
84e458ba78 Merge pull request #2728 from alphagov/fix_edit_button 
Fix bug that shows edit postage button on template to everyone
 2019-02-04 16:01:15 +00:00
Pea Tyczynska
06bf6254e3 Fix bug that shows edit postage button on template to everyone 2019-02-04 15:54:07 +00:00
Tom Byers
04ca620f46 Merge pull request #2726 from alphagov/fix-incorrect-use-of-inarray 
$.inArray returns the same value as Array.indexOf
 2019-02-04 15:23:40 +00:00
Chris Hill-Scott
ca6529dcdb Update app/assets/javascripts/templateFolderForm.js 
Use native `Array.indexOf` instead.

Co-Authored-By: tombye <tombaromba@gmail.com>
 2019-02-04 15:17:27 +00:00
Pea (Malgorzata Tyczynska)
189eabbe2a Merge pull request #2695 from alphagov/postage_on_template_not_on_service 
Edit postage per template and not through service settings
 2019-02-04 15:04:25 +00:00
Tom Byers
0e55521d8f $.inArray returns the same value as Array.indexOf 2019-02-04 14:56:18 +00:00
Pea Tyczynska
6b9f0675d1 Change styling of 'back to template' link on edit template postage page 2019-02-04 14:55:16 +00:00
Pea Tyczynska
29a860cf96 Move a full stop so it's outside the link 2019-02-04 14:55:16 +00:00
Pea Tyczynska
fe6b73b8dc Remove service postage setting and choose_postage switch 2019-02-04 14:55:16 +00:00
Pea Tyczynska
20ae200de9 Remove choosing postage from edit template content flow 2019-02-04 14:45:33 +00:00
Pea Tyczynska
e85678fa69 Add link to edit postage to view_template page 2019-02-04 14:45:33 +00:00
Pea Tyczynska
db5378bac2 Edit template postage from a separate view 2019-02-04 14:45:33 +00:00
Chris Hill-Scott
88f9d156c7 Warn if a file has been sent already 
We have some teams who haver a series of files they have to send each
day. It’s easy to get muddled up and accidentally send the same file
again, if you think you haven’t already sent it.

This commit blocks you from sending the same combination of template
version and filename more than once on the same day[1].

This won’t affect teams who re-use the same template to give (for
example) updates on an incident for business continuity. These teams
edit the template between each send, thereby updating the version
number of the template.

1. This is based on how the `limit_days` argument to the API works - you
can dig into the code here: 2bd4f74ad0/app/dao/jobs_dao.py (L50)
 2019-02-04 14:44:54 +00:00
pyup-bot
cc392e49a4 Update pytest-mock from 1.10.0 to 1.10.1 2019-02-04 13:55:27 +00:00
Tom Byers
2055a83516 Merge pull request #2723 from alphagov/fix-polyfill-issue 
Replace native Array.includes with jQuery version
 2019-02-04 11:32:39 +00:00
Tom Byers
7ef32a6bd9 Replace native Array.includes with jQuery version 
This was failing with a 'Object doesn't have
method' error on IE11. Assume Babel wasn't
polyfilling Array.includes so reverting to jQuery
version for now.
 2019-02-04 11:23:41 +00:00
Chris Hill-Scott
0368b06d2d Mark agreement signed by South Tyneside 2019-02-04 10:52:37 +00:00
Chris Hill-Scott
3140eb22ab Merge pull request #2721 from alphagov/lancs-wrecs 
Mark agreement signed by Lancashire and Wrexham
 2019-02-04 10:51:02 +00:00
Chris Hill-Scott
361ff2b525 Merge pull request #2715 from alphagov/remove-folder-toggle 
Remove button to toggle folders on/off
 2019-02-04 10:50:27 +00:00
Chris Hill-Scott
33f318afec Remove platform admin toggles for email/SMS 
Users can do this themselves now.
 2019-02-01 18:33:32 +00:00
Chris Hill-Scott
7905b29d64 Remove button to toggle folders on/off 
We don’t need it now that everyone has folders.
 2019-02-01 18:33:31 +00:00
Chris Hill-Scott
c4ea9a3c88 Mark agreement signed by Lancashire and Wrexham 2019-02-01 16:46:25 +00:00
Chris Hill-Scott
f283edeb12 Merge pull request #2720 from alphagov/wefwefewgfwegergerg 
Fix button for functional tests
 2019-02-01 16:20:51 +00:00
Chris Hill-Scott
c6445eda9f Fix button for functional tests 2019-02-01 16:19:20 +00:00
Chris Hill-Scott
6b02775927 Merge pull request #2718 from alphagov/sticky-footer-new-buttons 
Add sticky footer on letter contact details, fix issues
 2019-02-01 16:11:28 +00:00
Chris Hill-Scott
f55e2c06ef make invite button on org team consistent 2019-02-01 15:58:52 +00:00
Chris Hill-Scott
1c042567e6 Fix width of textbox on letter contact details page 2019-02-01 15:46:42 +00:00
Chris Hill-Scott
a11d24e816 Use sticky footer on letter contact details to match email reply to 2019-02-01 15:46:23 +00:00
Chris Hill-Scott
5597e63d44 Recalculate stickyness after API keys have rendered 2019-02-01 15:45:38 +00:00
Chris Hill-Scott
7632e6b9d3 Merge pull request #2717 from alphagov/sticky-footer-new-buttons 
Make ‘Add new’ buttons sticky on more pages
 2019-02-01 15:27:09 +00:00
Chris Hill-Scott
afdc749e36 Make ‘Add new’ buttons sticky on more pages 
For consistency with the template management page.
 2019-02-01 14:25:35 +00:00
Chris Hill-Scott
539c9f2368 Merge pull request #2716 from alphagov/ignore-case-sort-team-members 
Ignore case when sorting team members list
 2019-02-01 13:17:33 +00:00
Chris Hill-Scott
0e4a22e821 Ignore case when sorting team members list 
Otherwise you get A, B, C, a, b, c 😳
 2019-02-01 13:09:02 +00:00
Chris Hill-Scott
d7c108a2f5 Merge pull request #2713 from alphagov/full-width-new-folder 
Make ‘New folder’ textbox full width
 2019-02-01 12:38:19 +00:00
Chris Hill-Scott
cc8c2da66e Merge pull request #2714 from alphagov/tweak-spacing-of-folder-heading 
Normalise spacing of template breadcrumb heading
 2019-02-01 12:38:13 +00:00
Chris Hill-Scott
93df30d2df Normalise spacing of template breadcrumb heading 
Removes the magic numbers, makes it visually look like it’s in the same
position as the 36px type size headings.
 2019-02-01 12:22:36 +00:00