darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-25 08:44:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3419 from alphagov/sms-sender-length

Browse Source 
Reduce min sender length from 4 to 3
This commit is contained in:
David McDonald
2020-04-21 14:53:52 +01:00
committed by GitHub
parent 52e966337d 9f557dd086
commit f91aba212d
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/forms.py
View File

@@ -1063,7 +1063,7 @@ class ServiceSmsSenderForm(StripWhitespaceForm):
validators=[ validators=[
DataRequired(message="Cannot be empty"), DataRequired(message="Cannot be empty"),
Length(max=11, message="Enter 11 characters or fewer"), Length(max=11, message="Enter 11 characters or fewer"),
Length(min=4, message="Enter 4 characters or more"), Length(min=3, message="Enter 3 characters or more"),
LettersNumbersFullStopsAndUnderscoresOnly(), LettersNumbersFullStopsAndUnderscoresOnly(),
DoesNotStartWithDoubleZero(), DoesNotStartWithDoubleZero(),
] ]

6
tests/app/main/test_validators.py
View File

@@ -225,11 +225,11 @@ def test_sms_sender_form_validation(
form.validate() form.validate()
assert not form.errors assert not form.errors
form.sms_sender.data = '333' form.sms_sender.data = '22'
form.validate() form.validate()
assert 'Enter 4 characters or more' == form.errors['sms_sender'][0] assert 'Enter 3 characters or more' == form.errors['sms_sender'][0]
form.sms_sender.data = '4444' form.sms_sender.data = '333'
form.validate() form.validate()
assert not form.errors assert not form.errors