From 9f557dd0868373f1f6746cbb2044aef5a5c81639 Mon Sep 17 00:00:00 2001 From: David McDonald Date: Tue, 21 Apr 2020 12:51:54 +0100 Subject: [PATCH] Reduce min sender length from 4 to 3 This is now supported at the network and aggregator level --- app/main/forms.py | 2 +- tests/app/main/test_validators.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/main/forms.py b/app/main/forms.py index 46592daf9..7aa705e3f 100644 --- a/app/main/forms.py +++ b/app/main/forms.py @@ -1059,7 +1059,7 @@ class ServiceSmsSenderForm(StripWhitespaceForm): validators=[ DataRequired(message="Cannot be empty"), Length(max=11, message="Enter 11 characters or fewer"), - Length(min=4, message="Enter 4 characters or more"), + Length(min=3, message="Enter 3 characters or more"), LettersNumbersFullStopsAndUnderscoresOnly(), DoesNotStartWithDoubleZero(), ] diff --git a/tests/app/main/test_validators.py b/tests/app/main/test_validators.py index f58afd610..d0ab5e4f9 100644 --- a/tests/app/main/test_validators.py +++ b/tests/app/main/test_validators.py @@ -225,11 +225,11 @@ def test_sms_sender_form_validation( form.validate() assert not form.errors - form.sms_sender.data = '333' + form.sms_sender.data = '22' form.validate() - assert 'Enter 4 characters or more' == form.errors['sms_sender'][0] + assert 'Enter 3 characters or more' == form.errors['sms_sender'][0] - form.sms_sender.data = '4444' + form.sms_sender.data = '333' form.validate() assert not form.errors