darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-04 13:41:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename property to more accurately describe purpose

Browse Source 
`recently_created` says it would just be looking at the `created_at`
field to see if it's been created recently. Technically this method
isn't doing that, whilst its behaviour would be similar, it's actually
different and maybe therefore a bit misleading.
This commit is contained in:
Chris Hill-Scott
2020-01-21 14:07:23 +00:00
parent d93866bc7e
commit f6a263a7b2
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/job.py
View File

@@ -107,7 +107,7 @@ class Job(JSONModel):
return self.notification_count == self.notifications_sent
@property
def recently_created(self):
def awaiting_processing_or_recently_processed(self):
if not self.processing_started:
# Assume that if processing hasn’t started yet then the job
# must have been created recently enough to not have any

2
app/templates/partials/jobs/notifications.html
View File

@@ -47,7 +47,7 @@
notifications,
caption=uploaded_file_name,
caption_visible=False,
empty_message='No messages to show yet…' if job.recently_created else 'These messages have been deleted because they were sent more than {} days ago'.format(service_data_retention_days),
empty_message='No messages to show yet…' if job.awaiting_processing_or_recently_processed else 'These messages have been deleted because they were sent more than {} days ago'.format(service_data_retention_days),
field_headings=[
'Recipient',
'Status'