darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-24 20:31:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor inbound_sms to use switch_service_permissions

Browse Source
This commit is contained in:
Ken Tsang
2017-06-27 11:17:06 +01:00
parent beffaeaeea
commit f624215bbf
1 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
app/main/views/service_settings.py
View File

@@ -208,17 +208,19 @@ def service_switch_research_mode(service_id):
return redirect(url_for('.service_settings', service_id=service_id))
def switch_service_permissions(service_id, permission):
def switch_service_permissions(service_id, permission, sms_sender=None):
permissions = current_service['permissions'].copy()
if permission in permissions:
permissions.remove(permission)
else:
permissions.append(permission)
current_service['permissions'] = permissions
service_api_client.update_service_with_properties(
service_id,
{'permissions': permissions}
)
data = {'permissions': permissions}
if sms_sender:
data['sms_sender'] = sms_sender
service_api_client.update_service_with_properties(service_id, data)
@main.route("/services/<service_id>/service-settings/can-send-letters")
@@ -302,16 +304,7 @@ def service_set_sms_sender(service_id):
if form.validate_on_submit():
set_inbound_sms = request.args.get('set_inbound_sms', False)
if set_inbound_sms == 'True':
permissions = current_service['permissions']
if 'inbound_sms' in permissions:
permissions.remove('inbound_sms')
else:
permissions.append('inbound_sms')
service_api_client.update_service_with_properties(
current_service['id'],
{'permissions': permissions,
'sms_sender': form.sms_sender.data or None}
)
switch_service_permissions(current_service['id'], 'inbound_sms', form.sms_sender.data)
else:
service_api_client.update_service(
current_service['id'],