darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 09:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

rebreak the tests to reflect reality

Browse Source
This commit is contained in:
Kenneth Kehl
2024-03-07 09:59:58 -08:00
parent de38f38892
commit f42cf3bd22
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/views/jobs.py
View File

@@ -272,7 +272,7 @@ def get_status_filters(service, message_type, statistics):
if message_type is None:
stats = {
key: sum(statistics[message_type][key] for message_type in {"email", "sms"})
for key in {"requested", "delivered", "failed"}
for key in {"requested", "delivered", "failure"}
}
else:
stats = statistics[message_type]

3
tests/app/main/views/test_activity.py
View File

@@ -531,12 +531,13 @@ def test_time_left(job_created_at, expected_message):
assert get_time_left(job_created_at) == expected_message
STATISTICS = {"sms": {"requested": 6, "failed": 2, "delivered": 1, "pending": 3}}
STATISTICS = {"sms": {"requested": 6, "failed": 2, "delivered": 1}}
def test_get_status_filters_calculates_stats(client_request):
ret = get_status_filters(Service({"id": "foo"}), "sms", STATISTICS)
# TODO WHY DO WE THINK THE PENDING COUNT SHOULD BE 3? HOW DID THIS WORK BEFORE?
assert {label: count for label, _option, _link, count in ret} == {
"total": 6,
"pending": 3,