Show letters that fail validation as cancelled

At the moment we show precompiled letters that have failed the
validation as having been sent. This is confusing.

We should communicate it as having been cancelled (rather than failed),
with the implication being that Notify has come along and cancelled the
letter before printing it. I think this is conceptually what makes the
most sense.

From the user’s point of view any letters that show up as cancelled
probably need to be fixed and resent, so it makes sense to group them
with the same name.

app/templates/components/table.html

@@ -162,7 +162,7 @@
           notification.template.template_type
         ) }}
       {% endif %}
-      {% if notification.notification_type == "letter" and notification.status == 'permanent-failure' %}
+      {% if notification.notification_type == "letter" and notification.status in ['permanent-failure', 'validation-failed'] %}
         Cancelled
       {% endif %}
       {% if notification.status|format_notification_status_as_url(notification.notification_type) %}

app/templates/views/notifications/notification.html

@@ -39,6 +39,11 @@
         <p class="notification-status-cancelled">
           Cancelled {{ updated_at|format_datetime_short }}
         </p>
+      {% elif notification_status == 'validation-failed' %}
+        <p class="notification-status-cancelled">
+          Cancelled {{ updated_at|format_datetime_short }}
+          (letter has content outside the printable area)
+        </p>
       {% else %}
         <p>
           Postage: {{ postage }} class

tests/app/main/views/test_activity.py

@@ -547,6 +547,7 @@ def test_big_numbers_and_search_dont_show_for_letters(
         ('sms', 'delivered', 'Delivered 27 September at 5:31pm', True),
         ('letter', 'delivered', '27 September at 5:30pm', True),
         ('letter', 'permanent-failure', 'Cancelled 27 September at 5:31pm', False),
+        ('letter', 'validation-failed', 'Cancelled 27 September at 5:30pm', False),
     ]
 )
 def test_sending_status_hint_does_not_include_status_for_letters(

tests/app/main/views/test_notifications.py

@@ -174,18 +174,30 @@ def test_notification_page_shows_page_for_letter_notification(
         )
 
 
+@pytest.mark.parametrize('notification_status, expected_message', (
+    (
+        'permanent-failure',
+        'Cancelled 1 January at 1:02am',
+    ),
+    (
+        'validation-failed',
+        'Cancelled 1 January at 1:02am (letter has content outside the printable area)',
+    ),
+))
 @freeze_time("2016-01-01 01:01")
 def test_notification_page_shows_cancelled_letter(
     client_request,
     mocker,
     fake_uuid,
+    notification_status,
+    expected_message,
 ):
 
     mock_get_notification(
         mocker,
         fake_uuid,
         template_type='letter',
-        notification_status='permanent-failure',
+        notification_status=notification_status,
     )
     mocker.patch(
         'app.main.views.notifications.get_page_count_for_letter',
@@ -202,7 +214,7 @@ def test_notification_page_shows_cancelled_letter(
         'sample template sent by Test User on 1 January at 1:01am'
     )
     assert normalize_spaces(page.select('main p')[1].text) == (
-        'Cancelled 1 January at 1:02am'
+        expected_message
     )
     assert not page.select('p.notification-status')