Adding logging.

Raise ValidationError for validate_codes rather than returning a true or false.
This commit is contained in:
Rebecca Law
2016-01-05 13:13:06 +00:00
parent 1fd6ce9fe4
commit f1291b7c09
2 changed files with 21 additions and 20 deletions

View File

@@ -95,18 +95,14 @@ class AddServiceForm(Form):
def validate_codes(field, code_type):
codes = verify_codes_dao.get_codes(user_id=session['user_id'], code_type=code_type)
is_valid = len([code for code in codes if validate_code(field, code)]) == 1
if is_valid:
field.errors.clear()
return is_valid
print('validate_codes for user_id: {} are {}'.format(session['user_id'], codes))
if not [code for code in codes if validate_code(field, code)]:
raise ValidationError('Code does not match')
def validate_code(field, code):
if field.data and check_hash(field.data, code.code):
if code.expiry_datetime <= datetime.now():
field.errors.append('Code has expired')
return False
return True
else:
field.errors.append('Code does not match')
return False
raise ValidationError('Code has expired')
else:
return code.code

View File

@@ -1,3 +1,5 @@
import traceback
from flask import render_template, redirect, jsonify, session
from flask_login import login_user
@@ -13,13 +15,16 @@ def render_verify():
@main.route('/verify', methods=['POST'])
def process_verify():
form = VerifyForm()
if form.validate_on_submit():
user = users_dao.get_user_by_id(session['user_id'])
verify_codes_dao.use_code_for_user_and_type(user_id=user.id, code_type='email')
verify_codes_dao.use_code_for_user_and_type(user_id=user.id, code_type='sms')
users_dao.activate_user(user.id)
login_user(user)
return redirect('/add-service')
else:
return jsonify(form.errors), 400
try:
form = VerifyForm()
if form.validate_on_submit():
user = users_dao.get_user_by_id(session['user_id'])
verify_codes_dao.use_code_for_user_and_type(user_id=user.id, code_type='email')
verify_codes_dao.use_code_for_user_and_type(user_id=user.id, code_type='sms')
users_dao.activate_user(user.id)
login_user(user)
return redirect('/add-service')
else:
return jsonify(form.errors), 400
except:
traceback.print_exc()