darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-05 19:03:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

downgrade non-gsm chars in SMS previews

Browse Source 
bump utils to 13.8.0

we still save the content as the user intended, and they'll still see
that content in the text field if they go to edit the template, but
the SMS previews will appear as they will on a user's phone
This commit is contained in:
Leo Hemsted
2017-02-20 12:03:16 +00:00
parent fea7758eaf
commit efd976e32e
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
requirements.txt
View File

@@ -33,4 +33,4 @@ notifications-python-client>=3.1,<3.2
awscli>=1.11,<1.12
awscli-cwlogs>=1.4,<1.5
git+https://github.com/alphagov/notifications-utils.git@13.7.0#egg=notifications-utils==13.7.0
git+https://github.com/alphagov/notifications-utils.git@13.8.0#egg=notifications-utils==13.8.0

7
tests/app/main/views/test_templates.py
View File

@@ -32,13 +32,14 @@ def test_should_show_page_for_one_template(
mock_get_service_template.assert_called_with(service_one['id'], template_id)
def test_should_show_sms_template_without_downgrading_unicode_characters(
def test_should_show_sms_template_with_downgraded_unicode_characters(
logged_in_client,
mocker,
service_one,
fake_uuid,
):
msg = 'here:\tare some “fancy quotes” and non\u200Bbreaking\u200Bspaces'
msg = 'here:\tare some “fancy quotes” and zero\u200Bwidth\u200Bspaces'
rendered_msg = 'here: are some "fancy quotes" and zerowidthspaces'
mocker.patch(
'app.service_api_client.get_service_template',
@@ -52,7 +53,7 @@ def test_should_show_sms_template_without_downgrading_unicode_characters(
template_id=template_id))
assert response.status_code == 200
assert msg in response.get_data(as_text=True)
assert rendered_msg in response.get_data(as_text=True)
def test_should_show_page_template_with_priority_select_if_platform_admin(