darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 17:38:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Mutate dictionary instead of creating new one

Browse Source 
Stops the case where keyword arguments could conflict.
This commit is contained in:
Chris Hill-Scott
2017-06-30 15:18:03 +01:00
parent 0b296ed8de
commit ef567210ff
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/main/views/notifications.py
View File

@@ -115,16 +115,9 @@ def get_all_personalisation_from_notification(notification):
notification['personalisation'] = {}
if notification['template']['template_type'] == 'email':
return dict(
email_address=notification['to'],
**notification['personalisation']
)
notification['personalisation']['email_address'] = notification['to']
if notification['template']['template_type'] == 'sms':
return dict(
phone_number=notification['to'],
**notification['personalisation']
)
notification['personalisation']['phone_number'] = notification['to']
if notification['template']['template_type'] == 'letter':
return notification['personalisation']
return notification['personalisation']