darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-11 10:28:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Stop using -govuk-spacing(n) in SASS

Browse Source 
Using `-govuk-spacing(n)` in the SASS files was not working, so this
replaces it with `-1 * govuk-spacing(n)` instead.
This commit is contained in:
Katie Smith
2020-03-06 11:23:24 +00:00
parent e2099d6170
commit ee9a396de1
9 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/assets/stylesheets/app.scss
+1 -1
View File
@@ -91,7 +91,7 @@ details summary {
.spreadsheet { .spreadsheet {
margin-bottom: -govuk-spacing(6); margin-bottom: -1 * govuk-spacing(6);
.table { .table {
margin-bottom: 0; margin-bottom: 0;
app/assets/stylesheets/components/banner.scss
+2 -2
View File
@@ -88,7 +88,7 @@
} }
& + p { & + p {
margin-top: -govuk-spacing(3); margin-top: -1 * govuk-spacing(3);
} }
} }
@@ -175,7 +175,7 @@
} }
& + .banner-dashboard { & + .banner-dashboard {
margin-top: -govuk-spacing(6); margin-top: -1 * govuk-spacing(6);
border-top: none; border-top: none;
} }
} }
app/assets/stylesheets/components/conditional-radios.scss
+1 -1
View File
@@ -17,7 +17,7 @@ $top-spacing: govuk-spacing(5);
&-panel { &-panel {
border-left: $border-thickness solid $border-colour; border-left: $border-thickness solid $border-colour;
margin: 0 0 (-govuk-spacing(3)) (govuk-spacing(3) + ($border-thickness / 2)); margin: 0 0 (-1 * govuk-spacing(3)) (govuk-spacing(3) + ($border-thickness / 2));
padding: govuk-spacing(3) 0 0 (govuk-spacing(6) - ($border-thickness / 2)); padding: govuk-spacing(3) 0 0 (govuk-spacing(6) - ($border-thickness / 2));
position: relative; position: relative;
top: -$top-spacing; top: -$top-spacing;
app/assets/stylesheets/components/message.scss
+1 -1
View File
@@ -31,7 +31,7 @@
margin: 0; margin: 0;
a { a {
margin-bottom: -govuk-spacing(6); margin-bottom: -1 * govuk-spacing(6);
padding-bottom: govuk-spacing(6); padding-bottom: govuk-spacing(6);
&:hover .message-name-separator:before { &:hover .message-name-separator:before {
app/assets/stylesheets/components/stick-at-top-when-scrolling.scss
+1 -1
View File
@@ -7,7 +7,7 @@ $sticky-padding: govuk-spacing(4);
.js-stick-at-bottom-when-scrolling { .js-stick-at-bottom-when-scrolling {
overflow: hidden; overflow: hidden;
margin-left: -govuk-spacing(3); margin-left: -1 * govuk-spacing(3);
padding: 10px 0 0 govuk-spacing(3); padding: 10px 0 0 govuk-spacing(3);
position: relative; position: relative;
app/assets/stylesheets/components/table.scss
+4 -4
View File
@@ -343,10 +343,10 @@
position: absolute; position: absolute;
top: -govuk-spacing(3); top: -1 * govuk-spacing(3);
right: 0; right: 0;
bottom: -govuk-spacing(3) + 4px; bottom: -1 * govuk-spacing(3) + 4px;
left: -govuk-spacing(3); left: -1 * govuk-spacing(3);
background: transparent; background: transparent;
} }
@@ -387,7 +387,7 @@ td.table-empty-message {
text-align: center; text-align: center;
.table + & { .table + & {
margin-top: -govuk-spacing(6); margin-top: -1 * govuk-spacing(6);
} }
} }
app/assets/stylesheets/components/tick-cross.scss
+3 -3
View File
@@ -51,10 +51,10 @@
position: absolute; position: absolute;
top: -govuk-spacing(3) - 1; top: -1 * govuk-spacing(3) - 1;
right: 0; right: 0;
bottom: -govuk-spacing(3); bottom: -1 * govuk-spacing(3);
left: -govuk-spacing(3); left: -1 * govuk-spacing(3);
background: transparent; background: transparent;
} }
app/assets/stylesheets/components/vendor/previous-next-navigation.scss
Vendored
+2 -2
View File
@@ -32,8 +32,8 @@ $is-ie: false !default;
display: block; display: block;
margin-top: govuk-spacing(6); margin-top: govuk-spacing(6);
margin-bottom: govuk-spacing(6); margin-bottom: govuk-spacing(6);
margin-left: -govuk-spacing(3); margin-left: -1 * govuk-spacing(3);
margin-right: -govuk-spacing(3); margin-right: -1 * govuk-spacing(3);
overflow: hidden; overflow: hidden;
ul { ul {
app/assets/stylesheets/views/notification.scss
+1 -1
View File
@@ -2,7 +2,7 @@
@include core-16; @include core-16;
color: $secondary-text-colour; color: $secondary-text-colour;
margin-top: -govuk-spacing(3); margin-top: -1 * govuk-spacing(3);
&.error { &.error {