darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-18 13:39:57 -04:00
Code Issues Packages Projects Releases Wiki Activity

Stop using -govuk-spacing(n) in SASS

Browse Source 
Using `-govuk-spacing(n)` in the SASS files was not working, so this
replaces it with `-1 * govuk-spacing(n)` instead.
This commit is contained in:
Katie Smith
2020-03-06 11:23:24 +00:00
parent e2099d6170
commit ee9a396de1
9 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/stylesheets/app.scss
View File

@@ -91,7 +91,7 @@ details summary {
.spreadsheet {
margin-bottom: -govuk-spacing(6);
margin-bottom: -1 * govuk-spacing(6);
.table {
margin-bottom: 0;

4
app/assets/stylesheets/components/banner.scss
View File

@@ -88,7 +88,7 @@
}
& + p {
margin-top: -govuk-spacing(3);
margin-top: -1 * govuk-spacing(3);
}
}
@@ -175,7 +175,7 @@
}
& + .banner-dashboard {
margin-top: -govuk-spacing(6);
margin-top: -1 * govuk-spacing(6);
border-top: none;
}
}

2
app/assets/stylesheets/components/conditional-radios.scss
View File

@@ -17,7 +17,7 @@ $top-spacing: govuk-spacing(5);
&-panel {
border-left: $border-thickness solid $border-colour;
margin: 0 0 (-govuk-spacing(3)) (govuk-spacing(3) + ($border-thickness / 2));
margin: 0 0 (-1 * govuk-spacing(3)) (govuk-spacing(3) + ($border-thickness / 2));
padding: govuk-spacing(3) 0 0 (govuk-spacing(6) - ($border-thickness / 2));
position: relative;
top: -$top-spacing;

2
app/assets/stylesheets/components/message.scss
View File

@@ -31,7 +31,7 @@
margin: 0;
a {
margin-bottom: -govuk-spacing(6);
margin-bottom: -1 * govuk-spacing(6);
padding-bottom: govuk-spacing(6);
&:hover .message-name-separator:before {

2
app/assets/stylesheets/components/stick-at-top-when-scrolling.scss
View File

@@ -7,7 +7,7 @@ $sticky-padding: govuk-spacing(4);
.js-stick-at-bottom-when-scrolling {
overflow: hidden;
margin-left: -govuk-spacing(3);
margin-left: -1 * govuk-spacing(3);
padding: 10px 0 0 govuk-spacing(3);
position: relative;

8
app/assets/stylesheets/components/table.scss
View File

@@ -343,10 +343,10 @@
position: absolute;
top: -govuk-spacing(3);
top: -1 * govuk-spacing(3);
right: 0;
bottom: -govuk-spacing(3) + 4px;
left: -govuk-spacing(3);
bottom: -1 * govuk-spacing(3) + 4px;
left: -1 * govuk-spacing(3);
background: transparent;
}
@@ -387,7 +387,7 @@ td.table-empty-message {
text-align: center;
.table + & {
margin-top: -govuk-spacing(6);
margin-top: -1 * govuk-spacing(6);
}
}

6
app/assets/stylesheets/components/tick-cross.scss
View File

@@ -51,10 +51,10 @@
position: absolute;
top: -govuk-spacing(3) - 1;
top: -1 * govuk-spacing(3) - 1;
right: 0;
bottom: -govuk-spacing(3);
left: -govuk-spacing(3);
bottom: -1 * govuk-spacing(3);
left: -1 * govuk-spacing(3);
background: transparent;
}

4
app/assets/stylesheets/components/vendor/previous-next-navigation.scss vendored
View File

@@ -32,8 +32,8 @@ $is-ie: false !default;
display: block;
margin-top: govuk-spacing(6);
margin-bottom: govuk-spacing(6);
margin-left: -govuk-spacing(3);
margin-right: -govuk-spacing(3);
margin-left: -1 * govuk-spacing(3);
margin-right: -1 * govuk-spacing(3);
overflow: hidden;
ul {

2
app/assets/stylesheets/views/notification.scss
View File

@@ -2,7 +2,7 @@
@include core-16;
color: $secondary-text-colour;
margin-top: -govuk-spacing(3);
margin-top: -1 * govuk-spacing(3);
&.error {