darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-05 16:38:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Stop Redis exception by not passing Redis an empty set to delete

Browse Source 
We use `redis_client.delete` to delete multiple keys at once, but this
raises a `redis.exceptions.ResponseError` if it is called with an empty list
or set. We should only call `redis_client.delete` when there is at least
one item to delete.
This commit is contained in:
Katie Smith
2018-12-31 15:04:52 +00:00
parent bbaa51443a
commit ed84e0958a
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/notify_client/template_folder_api_client.py
View File

@@ -38,10 +38,11 @@ class TemplateFolderAPIClient(NotifyAdminAPIClient):
'folders': list(folder_ids), 'folders': list(folder_ids),
}) })
self.redis_client.delete(*map( if template_ids:
'template-{}-version-None'.format, self.redis_client.delete(*map(
template_ids, 'template-{}-version-None'.format,
)) template_ids,
))
@cache.delete('service-{service_id}-template-folders') @cache.delete('service-{service_id}-template-folders')
def update_template_folder(self, service_id, template_folder_id, name): def update_template_folder(self, service_id, template_folder_id, name):