From ed84e0958adb02e0487d4eefb89264355440988a Mon Sep 17 00:00:00 2001 From: Katie Smith Date: Mon, 31 Dec 2018 15:04:52 +0000 Subject: [PATCH] Stop Redis exception by not passing Redis an empty set to delete We use `redis_client.delete` to delete multiple keys at once, but this raises a `redis.exceptions.ResponseError` if it is called with an empty list or set. We should only call `redis_client.delete` when there is at least one item to delete. --- app/notify_client/template_folder_api_client.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/notify_client/template_folder_api_client.py b/app/notify_client/template_folder_api_client.py index 8dae6ef61..93677dfc8 100644 --- a/app/notify_client/template_folder_api_client.py +++ b/app/notify_client/template_folder_api_client.py @@ -38,10 +38,11 @@ class TemplateFolderAPIClient(NotifyAdminAPIClient): 'folders': list(folder_ids), }) - self.redis_client.delete(*map( - 'template-{}-version-None'.format, - template_ids, - )) + if template_ids: + self.redis_client.delete(*map( + 'template-{}-version-None'.format, + template_ids, + )) @cache.delete('service-{service_id}-template-folders') def update_template_folder(self, service_id, template_folder_id, name):