darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-06 03:13:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues raised in pull request

Browse Source 
Includes:
- replacing of conditional with statement that
  returns the same values
- making lins to GDS page actually go there
This commit is contained in:
Tom Byers
2019-10-30 10:17:32 +00:00
parent ae27e94a35
commit ec72bcd00c
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/navigation.py
View File

@@ -330,9 +330,7 @@ class HeaderNavigation(Navigation):
# header HTML now comes from GOVUK Frontend so requires a boolean, not an attribute
def is_selected(self, navigation_item):
if request.endpoint in self.mapping[navigation_item]:
return True
return False
return request.endpoint in self.mapping[navigation_item]
class MainNavigation(Navigation):

4
app/templates/admin_template.html
View File

@@ -139,9 +139,9 @@
] %}
{% if current_service and current_service.research_mode %}
{% set meta_suffix = 'Built by the <a href="#" class="govuk-footer__link">Government Digital Service</a><span id="research-mode" class="research-mode">research mode</span>' %}
{% set meta_suffix = 'Built by the <a href="https://www.gov.uk/government/organisations/government-digital-service" class="govuk-footer__link">Government Digital Service</a><span id="research-mode" class="research-mode">research mode</span>' %}
{% else %}
{% set meta_suffix = 'Built by the <a href="#" class="govuk-footer__link">Government Digital Service</a>' %}
{% set meta_suffix = 'Built by the <a href="https://www.gov.uk/government/organisations/government-digital-service" class="govuk-footer__link">Government Digital Service</a>' %}
{% endif %}
{{ notify_footer({