darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-16 20:49:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename variable to be more descriptive

Browse Source 
> "normal" is a word that does not really tell much, could we maybe name
> this constant better?

‘Non-scheduled’ more explicitly describes that statues in this set.
This commit is contained in:
Chris Hill-Scott
2018-07-31 09:57:55 +01:00
parent 505de52d38
commit eb8e433820
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/notify_client/job_api_client.py
View File

@@ -16,7 +16,7 @@ class JobApiClient(NotifyAdminAPIClient):
'sent to dvla' 'sent to dvla'
} }
NORMAL_JOB_STATUSES = JOB_STATUSES - {'scheduled', 'cancelled'} NON_SCHEDULED_JOB_STATUSES = JOB_STATUSES - {'scheduled', 'cancelled'}
def __init__(self): def __init__(self):
super().__init__("a" * 73, "b") super().__init__("a" * 73, "b")
@@ -65,7 +65,7 @@ class JobApiClient(NotifyAdminAPIClient):
def get_page_of_jobs(self, service_id, page): def get_page_of_jobs(self, service_id, page):
return self.get_jobs( return self.get_jobs(
service_id, service_id,
statuses=self.NORMAL_JOB_STATUSES, statuses=self.NON_SCHEDULED_JOB_STATUSES,
page=page, page=page,
) )
@@ -73,7 +73,7 @@ class JobApiClient(NotifyAdminAPIClient):
return self.get_jobs( return self.get_jobs(
service_id, service_id,
limit_days=7, limit_days=7,
statuses=self.NORMAL_JOB_STATUSES, statuses=self.NON_SCHEDULED_JOB_STATUSES,
)['data'] )['data']
def get_scheduled_jobs(self, service_id): def get_scheduled_jobs(self, service_id):