From eb8e433820d2b83bcc4a3d1ef09a78ef2cfe6d2a Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Tue, 31 Jul 2018 09:57:55 +0100 Subject: [PATCH] Rename variable to be more descriptive MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > "normal" is a word that does not really tell much, could we maybe name > this constant better? ‘Non-scheduled’ more explicitly describes that statues in this set. --- app/notify_client/job_api_client.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/notify_client/job_api_client.py b/app/notify_client/job_api_client.py index a6e4ad36f..c214cc447 100644 --- a/app/notify_client/job_api_client.py +++ b/app/notify_client/job_api_client.py @@ -16,7 +16,7 @@ class JobApiClient(NotifyAdminAPIClient): 'sent to dvla' } - NORMAL_JOB_STATUSES = JOB_STATUSES - {'scheduled', 'cancelled'} + NON_SCHEDULED_JOB_STATUSES = JOB_STATUSES - {'scheduled', 'cancelled'} def __init__(self): super().__init__("a" * 73, "b") @@ -65,7 +65,7 @@ class JobApiClient(NotifyAdminAPIClient): def get_page_of_jobs(self, service_id, page): return self.get_jobs( service_id, - statuses=self.NORMAL_JOB_STATUSES, + statuses=self.NON_SCHEDULED_JOB_STATUSES, page=page, ) @@ -73,7 +73,7 @@ class JobApiClient(NotifyAdminAPIClient): return self.get_jobs( service_id, limit_days=7, - statuses=self.NORMAL_JOB_STATUSES, + statuses=self.NON_SCHEDULED_JOB_STATUSES, )['data'] def get_scheduled_jobs(self, service_id):