mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-11 09:28:27 -04:00
Refactor following review
This commit is contained in:
@@ -268,9 +268,7 @@ class Service(JSONModel):
|
||||
|
||||
@property
|
||||
def shouldnt_use_govuk_as_sms_sender(self):
|
||||
return self.organisation_type in {
|
||||
'local', 'nhs', 'nhs_local', 'nhs_central', 'emergency_service', 'school_or_college', 'other'
|
||||
}
|
||||
return self.organisation_type != 'central'
|
||||
|
||||
@cached_property
|
||||
def sms_senders(self):
|
||||
|
||||
@@ -900,7 +900,7 @@ def test_should_not_show_go_live_button_if_checklist_not_complete(
|
||||
),
|
||||
pytest.param(
|
||||
1,
|
||||
None,
|
||||
'central',
|
||||
99,
|
||||
[{'is_default': True, 'sms_sender': 'GOVUK'}],
|
||||
'',
|
||||
@@ -931,14 +931,14 @@ def test_should_not_show_go_live_button_if_checklist_not_complete(
|
||||
),
|
||||
(
|
||||
1,
|
||||
'local',
|
||||
'nhs_local',
|
||||
0,
|
||||
[],
|
||||
'Change your text message sender name Not completed',
|
||||
),
|
||||
(
|
||||
None,
|
||||
'local',
|
||||
'school_or_college',
|
||||
1,
|
||||
[{'is_default': True, 'sms_sender': 'GOVUK'}],
|
||||
'Change your text message sender name Not completed',
|
||||
|
||||
Reference in New Issue
Block a user