darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 05:59:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make error message specific to template type

Browse Source
This commit is contained in:
Chris Hill-Scott
2020-07-03 15:46:00 +01:00
parent f3115c0cea
commit e832d18002
4 changed files with 42 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
tests/app/main/views/test_templates.py
View File

@@ -1994,14 +1994,20 @@ def test_can_create_email_template_with_emoji(
assert mock_create_service_template.called is True
@pytest.mark.parametrize('template_type', (
'sms', 'broadcast'
@pytest.mark.parametrize('template_type, expected_error', (
('sms', (
'You cannot use 🍜 in text messages.'
)),
('broadcast', (
'You cannot use 🍜 in broadcasts.'
)),
))
def test_should_not_create_sms_or_broadcast_template_with_emoji(
client_request,
service_one,
mock_create_service_template,
template_type,
expected_error,
):
service_one['permissions'] += [template_type]
page = client_request.post(
@@ -2017,22 +2023,37 @@ def test_should_not_create_sms_or_broadcast_template_with_emoji(
},
_expected_status=200,
)
assert "You cannot use 🍜 in text messages." in page.text
assert expected_error in page.text
assert mock_create_service_template.called is False
@pytest.mark.parametrize('template_type', (
'sms', 'broadcast'
@pytest.mark.parametrize('template_type, expected_error', (
('sms', (
'You cannot use 🍔 in text messages.'
)),
('broadcast', (
'You cannot use 🍔 in broadcasts.'
)),
))
def test_should_not_update_sms_template_with_emoji(
mocker,
client_request,
service_one,
mock_get_service_template,
mock_update_service_template,
fake_uuid,
template_type,
expected_error,
):
service_one['permissions'] += [template_type]
return mocker.patch(
'app.service_api_client.get_service_template',
return_value=template_json(
SERVICE_ONE_ID,
fake_uuid,
type_=template_type,
),
)
page = client_request.post(
'.edit_service_template',
service_id=SERVICE_ONE_ID,
@@ -2047,7 +2068,7 @@ def test_should_not_update_sms_template_with_emoji(
},
_expected_status=200,
)
assert "You cannot use 🍔 in text messages." in page.text
assert expected_error in page.text
assert mock_update_service_template.called is False