darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don’t implement separate __getitem__ for invited users

Browse Source 
It can inherit now because both `User.__init__` and
`InvitedUser.__init__` have the same method signature.
This commit is contained in:
Chris Hill-Scott
2019-06-05 14:54:48 +01:00
parent bd9acb1310
commit e43f78a72d
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/user.py
View File

@@ -528,12 +528,13 @@ class AnonymousUser(AnonymousUserMixin):
class Users(Sequence): class Users(Sequence):
client = user_api_client.get_users_for_service client = user_api_client.get_users_for_service
model = User
def __init__(self, service_id): def __init__(self, service_id):
self.users = self.client(service_id) self.users = self.client(service_id)
def __getitem__(self, index): def __getitem__(self, index):
return User(self.users[index]) return self.model(self.users[index])
def __len__(self): def __len__(self):
return len(self.users) return len(self.users)
@@ -557,9 +558,6 @@ class InvitedUsers(Users):
if user['status'] != 'accepted' if user['status'] != 'accepted'
] ]
def __getitem__(self, index):
return self.model(self.users[index])
class OrganisationInvitedUsers(InvitedUsers): class OrganisationInvitedUsers(InvitedUsers):
client = org_invite_api_client.get_invites_for_organisation client = org_invite_api_client.get_invites_for_organisation