From e43f78a72da347a5a1ef070bfca0069ac7dbe812 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 5 Jun 2019 14:54:48 +0100 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20implement=20separate=20=5F=5Fge?= =?UTF-8?q?titem=5F=5F=20for=20invited=20users?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It can inherit now because both `User.__init__` and `InvitedUser.__init__` have the same method signature. --- app/models/user.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/models/user.py b/app/models/user.py index 764f13470..dec7c9692 100644 --- a/app/models/user.py +++ b/app/models/user.py @@ -528,12 +528,13 @@ class AnonymousUser(AnonymousUserMixin): class Users(Sequence): client = user_api_client.get_users_for_service + model = User def __init__(self, service_id): self.users = self.client(service_id) def __getitem__(self, index): - return User(self.users[index]) + return self.model(self.users[index]) def __len__(self): return len(self.users) @@ -557,9 +558,6 @@ class InvitedUsers(Users): if user['status'] != 'accepted' ] - def __getitem__(self, index): - return self.model(self.users[index]) - class OrganisationInvitedUsers(InvitedUsers): client = org_invite_api_client.get_invites_for_organisation