darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 17:38:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Small changes to address PR comments

Browse Source 
In response to [^1] and [^2].

[^1]: https://github.com/alphagov/notifications-admin/pull/4199#discussion_r842653983
[^2]: https://github.com/alphagov/notifications-admin/pull/4199#discussion_r842667340
This commit is contained in:
Ben Thorner
2022-04-05 13:53:45 +01:00
parent 59f6b0b5d8
commit e02dbde378
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/app/main/views/test_providers.py
View File

@@ -65,7 +65,7 @@ email_provider_2 = {
'current_month_billable_sms': 0,
}
sms_provider_int_1 = {
sms_provider_intl_1 = {
'id': '67c770f5-918e-4afa-a5ff-880b9beb161d',
'active': False,
'priority': 10,
@@ -79,7 +79,7 @@ sms_provider_int_1 = {
'current_month_billable_sms': 0,
}
sms_provider_int_2 = {
sms_provider_intl_2 = {
'id': '67c770f5-918e-4afa-a5ff-880b9beb161d',
'active': False,
'priority': 10,
@@ -102,8 +102,8 @@ def stub_providers():
sms_provider_2,
email_provider_1,
email_provider_2,
sms_provider_int_1,
sms_provider_int_2,
sms_provider_intl_1,
sms_provider_intl_2,
]
}
@@ -444,8 +444,10 @@ def test_should_show_version_history_for_first_two_sms_providers(
return_value=stub_providers
)
# we get only get version info for the "primary" (first) provider
# in alphabetical order i.e. sms_provider_1
# Getting the history for one provider implicitly gives us the
# history of the other one (in a world with only two providers).
# The code picks the first provider in alphabetical order of its
# id i.e. sms_provider_1.
mocker.patch(
'app.provider_client.get_provider_versions',
return_value={'data': [