darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-16 03:10:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #492 from alphagov/better-two-factor-page

Browse Source 
Reword two factor page to match email confirmation page
This commit is contained in:
Chris Hill-Scott
2016-04-25 15:33:59 +01:00
parent 77885295f9 c551fd43e0
commit dd15e69f48
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/stylesheets/components/textbox.scss
View File

@@ -83,7 +83,7 @@
}
.textbox-help-link {
margin: 5px 0 0 0;
margin: 10px 0 0 0;
}
.textbox-right-aligned {

12
app/templates/views/two-factor.html
View File

@@ -11,20 +11,20 @@
<div class="grid-row">
<div class="column-two-thirds">
<h1 class="heading-large">Text verification</h1>
<h1 class="heading-large">Check your phone</h1>
<p>We've sent you a text message with a verification code.</p>
<p>We’ve sent you a text message with a verification code.</p>
<form autocomplete="off" method="post">
{{ textbox(
form.sms_code,
width='5em',
autofocus=True,
help_link=url_for('.verification_code_not_received'),
help_link_text='I haven’t received a text message'
autofocus=True
) }}
{{ page_footer(
"Continue"
"Continue",
secondary_link=url_for('.verification_code_not_received'),
secondary_link_text='Not received a text message?'
) }}
</form>
</div>

2
tests/app/main/views/test_two_factor.py
View File

@@ -15,7 +15,7 @@ def test_should_render_two_factor_page(app_,
'email': api_user_active.email_address}
response = client.get(url_for('main.two_factor'))
assert response.status_code == 200
assert '''We've sent you a text message with a verification code.''' in response.get_data(as_text=True)
assert '''We’ve sent you a text message with a verification code.''' in response.get_data(as_text=True)
def test_should_login_user_and_redirect_to_service_dashboard(app_,

4
tests/app/main/views/test_verify.py
View File

@@ -16,9 +16,9 @@ def test_should_return_verify_template(app_,
assert response.status_code == 200
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert page.h1.text == 'Text verification'
assert page.h1.text == 'Check your phone'
message = page.find_all('p')[1].text
assert message == "We've sent you a text message with a verification code."
assert message == "We’ve sent you a text message with a verification code."
def test_should_redirect_to_add_service_when_sms_code_is_correct(app_,