mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-23 11:51:05 -05:00
Silence errors from Python Client
Otherwise we start spamming Sentry with every 404 error log. Even
if the erorr is a 5xx, it depends on how we handle it in the calling
code as to whether we would want to consider it an error.
I didn't spot this in initial testing on Preview because the 404s in
Preview are only triggered due to the functional tests, which only run
when we're deploying something.
Arguably we shouldn't be logging at error level in our Python Client,
since we're also raising an exception [1]. But changing that would be
a can of worms as it's not an internal-only library.
[1]: 74a958de00/notifications_python_client/base.py (L118)
This commit is contained in:
@@ -3,6 +3,7 @@ import os
|
||||
import sentry_sdk
|
||||
from flask import Flask
|
||||
from sentry_sdk.integrations.flask import FlaskIntegration
|
||||
from sentry_sdk.integrations import logging
|
||||
|
||||
from app import create_app
|
||||
|
||||
@@ -13,7 +14,9 @@ sentry_sdk.init(
|
||||
attach_stacktrace=True,
|
||||
traces_sample_rate=0.00005 # avoid exceeding rate limits in Production
|
||||
)
|
||||
|
||||
sentry_sdk.set_level('error') # only record error logs or exceptions
|
||||
logging.ignore_logger('notifications_python_client.*') # ignore logs about 404s, etc.
|
||||
|
||||
application = Flask('app')
|
||||
|
||||
|
||||
Reference in New Issue
Block a user