darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-11 10:28:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename manage templates permission

Browse Source 
‘Add and edit’ is the language we use next to the checkbox.

Also helps disambiguate it from the ‘manage service’ permission.
This commit is contained in:
Chris Hill-Scott
2017-09-15 11:36:00 +01:00
parent 1be2101d07
commit d7370c1816
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/templates/views/manage-users.html
+2 -2
View File
@@ -53,7 +53,7 @@
) }} ) }}
{{ tick_cross( {{ tick_cross(
user.has_permissions(permissions=['manage_templates']), user.has_permissions(permissions=['manage_templates']),
'Manage templates' 'Add and edit templates'
) }} ) }}
{{ tick_cross( {{ tick_cross(
user.has_permissions(permissions=['manage_users', 'manage_settings']), user.has_permissions(permissions=['manage_users', 'manage_settings']),
@@ -94,7 +94,7 @@
) }} ) }}
{{ tick_cross( {{ tick_cross(
user.has_permissions(permissions=['manage_templates']), user.has_permissions(permissions=['manage_templates']),
'Edit templates' 'Add and edit templates'
) }} ) }}
{{ tick_cross( {{ tick_cross(
user.has_permissions(permissions=['manage_users', 'manage_settings']), user.has_permissions(permissions=['manage_users', 'manage_settings']),
tests/app/main/views/test_manage_users.py
+4 -4
View File
@@ -19,21 +19,21 @@ from tests.conftest import (
active_user_with_permissions, active_user_with_permissions,
( (
'Test User (you) ' 'Test User (you) '
'Can Send messages Can Manage templates Can Manage service Can Access API keys' 'Can Send messages Can Add and edit templates Can Manage service Can Access API keys'
), ),
), ),
( (
active_user_view_permissions, active_user_view_permissions,
( (
'Test User With Permissions (you) ' 'Test User With Permissions (you) '
'Can’t Send messages Can’t Manage templates Can’t Manage service Can’t Access API keys' 'Can’t Send messages Can’t Add and edit templates Can’t Manage service Can’t Access API keys'
), ),
), ),
( (
active_user_manage_template_permission, active_user_manage_template_permission,
( (
'Test User With Permissions (you) ' 'Test User With Permissions (you) '
'Can’t Send messages Can Manage templates Can’t Manage service Can’t Access API keys' 'Can’t Send messages Can Add and edit templates Can’t Manage service Can’t Access API keys'
), ),
), ),
]) ])
@@ -255,7 +255,7 @@ def test_manage_users_shows_invited_user(
assert page.h1.string.strip() == 'Team members' assert page.h1.string.strip() == 'Team members'
assert normalize_spaces(page.select('.user-list')[1].text) == ( assert normalize_spaces(page.select('.user-list')[1].text) == (
'invited_user@test.gov.uk ' 'invited_user@test.gov.uk '
'Can’t Send messages Can’t Edit templates Can’t Manage service Can Access API keys ' 'Can’t Send messages Can’t Add and edit templates Can’t Manage service Can Access API keys '
'Cancel invitation' 'Cancel invitation'
) )