From d7370c181692303bf668572c84092f6c7e2da770 Mon Sep 17 00:00:00 2001
From: Chris Hill-Scott <me@quis.cc>
Date: Thu, 14 Sep 2017 13:03:27 +0100
Subject: [PATCH] Rename manage templates permission
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

‘Add and edit’ is the language we use next to the checkbox.

Also helps disambiguate it from the ‘manage service’ permission.
---
 app/templates/views/manage-users.html     | 4 ++--
 tests/app/main/views/test_manage_users.py | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/templates/views/manage-users.html b/app/templates/views/manage-users.html
index fb79b3b8a..373c5b3a6 100644
--- a/app/templates/views/manage-users.html
+++ b/app/templates/views/manage-users.html
@@ -53,7 +53,7 @@
             ) }}
             {{ tick_cross(
               user.has_permissions(permissions=['manage_templates']),
-              'Manage templates'
+              'Add and edit templates'
             ) }}
             {{ tick_cross(
               user.has_permissions(permissions=['manage_users', 'manage_settings']),
@@ -94,7 +94,7 @@
               ) }}
               {{ tick_cross(
                 user.has_permissions(permissions=['manage_templates']),
-                'Edit templates'
+                'Add and edit templates'
               ) }}
               {{ tick_cross(
                 user.has_permissions(permissions=['manage_users', 'manage_settings']),
diff --git a/tests/app/main/views/test_manage_users.py b/tests/app/main/views/test_manage_users.py
index ce97036f0..2766cd032 100644
--- a/tests/app/main/views/test_manage_users.py
+++ b/tests/app/main/views/test_manage_users.py
@@ -19,21 +19,21 @@ from tests.conftest import (
         active_user_with_permissions,
         (
             'Test User (you) '
-            'Can Send messages Can Manage templates Can Manage service Can Access API keys'
+            'Can Send messages Can Add and edit templates Can Manage service Can Access API keys'
         ),
     ),
     (
         active_user_view_permissions,
         (
             'Test User With Permissions (you) '
-            'Can’t Send messages Can’t Manage templates Can’t Manage service Can’t Access API keys'
+            'Can’t Send messages Can’t Add and edit templates Can’t Manage service Can’t Access API keys'
         ),
     ),
     (
         active_user_manage_template_permission,
         (
             'Test User With Permissions (you) '
-            'Can’t Send messages Can Manage templates Can’t Manage service Can’t Access API keys'
+            'Can’t Send messages Can Add and edit templates Can’t Manage service Can’t Access API keys'
         ),
     ),
 ])
@@ -255,7 +255,7 @@ def test_manage_users_shows_invited_user(
     assert page.h1.string.strip() == 'Team members'
     assert normalize_spaces(page.select('.user-list')[1].text) == (
         'invited_user@test.gov.uk '
-        'Can’t Send messages Can’t Edit templates Can’t Manage service Can Access API keys '
+        'Can’t Send messages Can’t Add and edit templates Can’t Manage service Can Access API keys '
         'Cancel invitation'
     )