darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-05 16:38:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2845 from alphagov/invite-auth-bug

Browse Source 
Fix choosing auth type when inviting new user
This commit is contained in:
Pea (Malgorzata Tyczynska)
2019-03-14 13:05:40 +00:00
committed by GitHub
parent 2bc6792c5a a9be6015dc
commit d5a16195d9
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/main/views/manage_users.py
View File

@@ -69,7 +69,8 @@ def invite_user(service_id):
return render_template( return render_template(
'views/invite-user.html', 'views/invite-user.html',
form=form, form=form,
service_has_email_auth=service_has_email_auth service_has_email_auth=service_has_email_auth,
mobile_number=True,
) )

13
tests/app/main/views/test_manage_users.py
View File

@@ -372,6 +372,19 @@ def test_should_show_page_for_one_user(
assert checkboxes[index].has_attr('checked') == expected_checked assert checkboxes[index].has_attr('checked') == expected_checked
def test_invite_user_allows_to_choose_auth(
client_request,
mock_get_users_by_service,
mock_get_template_folders,
service_one,
):
service_one['permissions'].append('email_auth')
page = client_request.get('main.invite_user', service_id=SERVICE_ONE_ID)
sms_auth_radio_button = page.select_one('input[value="sms_auth"]')
assert sms_auth_radio_button.has_attr("disabled") is False
def test_should_not_show_page_for_non_team_member( def test_should_not_show_page_for_non_team_member(
client_request, client_request,
mock_get_users_by_service, mock_get_users_by_service,