From 5aa72daf9b21bcda4370f8e6b889fc9a46b5596d Mon Sep 17 00:00:00 2001 From: Pea Tyczynska Date: Tue, 12 Mar 2019 11:41:52 +0000 Subject: [PATCH 1/2] Fix bug --- app/main/views/manage_users.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/main/views/manage_users.py b/app/main/views/manage_users.py index 8c954b767..8ddec98af 100644 --- a/app/main/views/manage_users.py +++ b/app/main/views/manage_users.py @@ -69,7 +69,8 @@ def invite_user(service_id): return render_template( 'views/invite-user.html', form=form, - service_has_email_auth=service_has_email_auth + service_has_email_auth=service_has_email_auth, + mobile_number=True, ) From a9be6015dc30fc16d6a54ccbe190faa1c22e5c72 Mon Sep 17 00:00:00 2001 From: Pea Tyczynska Date: Tue, 12 Mar 2019 16:53:46 +0000 Subject: [PATCH 2/2] Test if auth type can be chosen while inviting user --- tests/app/main/views/test_manage_users.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tests/app/main/views/test_manage_users.py b/tests/app/main/views/test_manage_users.py index 0ddf73223..2083e7550 100644 --- a/tests/app/main/views/test_manage_users.py +++ b/tests/app/main/views/test_manage_users.py @@ -372,6 +372,19 @@ def test_should_show_page_for_one_user( assert checkboxes[index].has_attr('checked') == expected_checked +def test_invite_user_allows_to_choose_auth( + client_request, + mock_get_users_by_service, + mock_get_template_folders, + service_one, +): + service_one['permissions'].append('email_auth') + page = client_request.get('main.invite_user', service_id=SERVICE_ONE_ID) + + sms_auth_radio_button = page.select_one('input[value="sms_auth"]') + assert sms_auth_radio_button.has_attr("disabled") is False + + def test_should_not_show_page_for_non_team_member( client_request, mock_get_users_by_service,