darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 16:24:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use ID for row to avoid guessing position

Browse Source 
This makes it easier to add / test other rows in future.
This commit is contained in:
Ben Thorner
2021-05-11 17:53:36 +01:00
parent 389f98f63c
commit d395d614b9
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/user-profile.html
View File

@@ -46,7 +46,7 @@
{% endcall %}
{% if current_user.platform_admin or session.get('disable_platform_admin_view') %}
{% call row() %}
{% call row(id='disable-platform-admin') %}
{{ text_field('Use platform admin view') }}
{{ text_field('Yes' if not session.get('disable_platform_admin_view') else 'No') }}
{{ edit_field('Change', url_for('.user_profile_disable_platform_admin_view')) }}

2
tests/app/main/views/test_user_profile.py
View File

@@ -23,7 +23,7 @@ def test_overview_page_shows_disable_for_platform_admin(
client_request.login(platform_admin_user)
page = client_request.get(('main.user_profile'))
assert page.select_one('h1').text.strip() == 'Your profile'
disable_platform_admin_row = page.select('tr')[-1]
disable_platform_admin_row = page.select_one('#disable-platform-admin')
assert ' '.join(disable_platform_admin_row.text.split()) == 'Use platform admin view Yes Change'