darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

notify-api-387 scan projects for unused code

Browse Source
This commit is contained in:
Kenneth Kehl
2023-08-08 12:12:15 -07:00
parent 5afecc2210
commit d36c70ed16
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/checks.yml vendored
View File

@@ -36,6 +36,8 @@ jobs:
run: pipenv run flake8 . run: pipenv run flake8 .
- name: Check imports alphabetized - name: Check imports alphabetized
run: pipenv run isort --check-only ./app ./tests run: pipenv run isort --check-only ./app ./tests
- name: Check dead code
run: make dead-code
- name: Run js lint - name: Run js lint
run: npm run lint run: npm run lint
- name: Run js tests - name: Run js tests

3
Makefile
View File

@@ -59,9 +59,6 @@ py-test: ## Run python unit tests
pipenv run coverage report --fail-under=96 pipenv run coverage report --fail-under=96
pipenv run coverage html -d .coverage_cache pipenv run coverage html -d .coverage_cache
.PHONY: dead-code
dead-code:
pipenv run vulture ./app --min-confidence=100
.PHONY: e2e-test .PHONY: e2e-test
e2e-test: export NEW_RELIC_ENVIRONMENT=test e2e-test: export NEW_RELIC_ENVIRONMENT=test

2
app/main/views/jobs.py
View File

@@ -165,7 +165,7 @@ def get_notifications_as_json(service_id, message_type=None):
endpoint="view_notifications_csv" endpoint="view_notifications_csv"
) )
@user_has_permissions() @user_has_permissions()
def get_notifications(service_id, message_type, status_override=None): def get_notifications(service_id, message_type, status_override=None): # noqa
# TODO get the api to return count of pages as well. # TODO get the api to return count of pages as well.
page = get_page_from_request() page = get_page_from_request()
if page is None: if page is None: