diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 1dc92d63f..c30ef6c57 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -36,6 +36,8 @@ jobs: run: pipenv run flake8 . - name: Check imports alphabetized run: pipenv run isort --check-only ./app ./tests + - name: Check dead code + run: make dead-code - name: Run js lint run: npm run lint - name: Run js tests diff --git a/Makefile b/Makefile index 3dc4030fa..c5335ed23 100644 --- a/Makefile +++ b/Makefile @@ -59,9 +59,6 @@ py-test: ## Run python unit tests pipenv run coverage report --fail-under=96 pipenv run coverage html -d .coverage_cache -.PHONY: dead-code -dead-code: - pipenv run vulture ./app --min-confidence=100 .PHONY: e2e-test e2e-test: export NEW_RELIC_ENVIRONMENT=test diff --git a/app/main/views/jobs.py b/app/main/views/jobs.py index fae1ac186..baf9655ef 100644 --- a/app/main/views/jobs.py +++ b/app/main/views/jobs.py @@ -165,7 +165,7 @@ def get_notifications_as_json(service_id, message_type=None): endpoint="view_notifications_csv" ) @user_has_permissions() -def get_notifications(service_id, message_type, status_override=None): +def get_notifications(service_id, message_type, status_override=None): # noqa # TODO get the api to return count of pages as well. page = get_page_from_request() if page is None: