darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 03:23:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove duplicative notifications_processed property

Browse Source 
It returned the same value (and had the same code as
`.notifications_sent`).

I think `.notifications_sent` is a better name because it’s closer to
the language (‘sending’ and ‘sent’) that we use in the interface.
This commit is contained in:
Chris Hill-Scott
2020-01-16 15:40:49 +00:00
parent fda979a5f2
commit cbf0d905e3
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/job.py
View File

@@ -70,10 +70,6 @@ class Job(JSONModel):
def notifications_sent(self): def notifications_sent(self):
return self.notifications_delivered + self.notifications_failed return self.notifications_delivered + self.notifications_failed
@property
def notifications_processed(self):
return self.notifications_delivered + self.notifications_failed
@property @property
def notifications_sending(self): def notifications_sending(self):
if self.scheduled: if self.scheduled:
@@ -94,7 +90,7 @@ class Job(JSONModel):
@cached_property @cached_property
def finished_processing(self): def finished_processing(self):
return self.notification_count == self.notifications_processed return self.notification_count == self.notifications_sent
@property @property
def template_id(self): def template_id(self):