From cbf0d905e3bc533bb3b36ed43a46284a0e32cca8 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Thu, 16 Jan 2020 15:40:49 +0000 Subject: [PATCH] Remove duplicative notifications_processed property MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It returned the same value (and had the same code as `.notifications_sent`). I think `.notifications_sent` is a better name because it’s closer to the language (‘sending’ and ‘sent’) that we use in the interface. --- app/models/job.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/models/job.py b/app/models/job.py index 3bd314f31..2b1eb4597 100644 --- a/app/models/job.py +++ b/app/models/job.py @@ -70,10 +70,6 @@ class Job(JSONModel): def notifications_sent(self): return self.notifications_delivered + self.notifications_failed - @property - def notifications_processed(self): - return self.notifications_delivered + self.notifications_failed - @property def notifications_sending(self): if self.scheduled: @@ -94,7 +90,7 @@ class Job(JSONModel): @cached_property def finished_processing(self): - return self.notification_count == self.notifications_processed + return self.notification_count == self.notifications_sent @property def template_id(self):