Rewrote some slighlt over complicated logic

This commit is contained in:
Martyn Inglis
2016-08-25 09:15:55 +01:00
parent 9b348880ef
commit c61199d17d

View File

@@ -78,14 +78,12 @@ def view_job(service_id, job_id):
filter_args = _parse_filter_args(request.args)
filter_args['status'] = _set_status_filters(filter_args)
finished = (
bool(job.get('notification_count', 0) and ((
job.get('notifications_delivered', 0) +
job.get('notifications_failed', 0)
) == job.get('notification_count', 0))))
total_notifications = job.get('notification_count', 0)
processed_notifications = job.get('notifications_delivered', 0) + job.get('notifications_failed', 0)
return render_template(
'views/jobs/job.html',
finished=finished,
finished=(total_notifications == processed_notifications),
uploaded_file_name=job['original_file_name'],
template=Template(
service_api_client.get_service_template(