mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-04-11 12:51:05 -04:00
Comma-delimit thousands in ‘Send’ button
Matches the style of how we display numbers in the thousands elsewhere.
This commit is contained in:
@@ -45,7 +45,7 @@
|
||||
) }}
|
||||
{% endif %}
|
||||
{% if (template.template_type != 'letter' or not request.args.from_test) and not letter_too_long %}
|
||||
<button type="submit" class="button">Send {{ count_of_recipients }} {{ message_count_label(count_of_recipients, template.template_type, suffix='') }}</button>
|
||||
<button type="submit" class="button">Send {{ count_of_recipients|format_thousands }} {{ message_count_label(count_of_recipients, template.template_type, suffix='') }}</button>
|
||||
{% else %}
|
||||
<a href="{{ url_for('main.check_messages_preview', service_id=current_service.id, template_id=template.id, upload_id=upload_id, filetype='pdf') }}" download class="button">Download as a PDF</a>
|
||||
{% endif %}
|
||||
|
||||
@@ -2162,6 +2162,36 @@ def test_letter_can_only_be_sent_now(
|
||||
)
|
||||
|
||||
|
||||
def test_send_button_is_correctly_labelled(
|
||||
client_request,
|
||||
mocker,
|
||||
mock_get_live_service,
|
||||
mock_get_service_template,
|
||||
mock_get_users_by_service,
|
||||
mock_get_service_statistics,
|
||||
mock_get_job_doesnt_exist,
|
||||
mock_get_jobs,
|
||||
fake_uuid,
|
||||
):
|
||||
mocker.patch('app.main.views.send.s3download', return_value='\n'.join(
|
||||
['phone_number'] + (['07900900123'] * 1000)
|
||||
))
|
||||
mocker.patch('app.main.views.send.set_metadata_on_csv_upload')
|
||||
|
||||
page = client_request.get(
|
||||
'main.check_messages',
|
||||
service_id=SERVICE_ONE_ID,
|
||||
upload_id=fake_uuid,
|
||||
template_id=fake_uuid,
|
||||
)
|
||||
|
||||
assert normalize_spaces(
|
||||
page.select_one('[type=submit]').text
|
||||
) == (
|
||||
'Send 1,000 text messages'
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.parametrize('when', [
|
||||
'', '2016-08-25T13:04:21.767198'
|
||||
])
|
||||
|
||||
Reference in New Issue
Block a user