darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-21 13:43:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

Added unit test for the data retention pages.

Browse Source
This commit is contained in:
Rebecca Law
2018-07-17 15:50:40 +01:00
parent 4b8b571a87
commit c2f973da95
2 changed files with 77 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
tests/app/main/views/test_service_settings.py
View File

@@ -95,7 +95,7 @@ def mock_get_service_settings_page_common(
'Free text message allowance 250,000 Change',
'Email branding GOV.UK Change',
'Letter branding HM Government Change',
'Data Retention Change'
'Data Retention email Change'
]),
])
@@ -2793,3 +2793,60 @@ def test_submit_email_branding_request(
'Thanks for your branding request. We’ll get back to you '
'within one working day.'
)
def test_show_service_data_retention(
logged_in_platform_admin_client,
service_one,
mock_get_service_data_retention,
):
response = logged_in_platform_admin_client.get(url_for('main.data_retention', service_id=service_one['id']))
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert normalize_spaces(page.select_one('main p').text) == "Email notifications will be kept for 5 days Change"
def test_view_add_service_data_retention(
logged_in_platform_admin_client,
service_one,
):
response = logged_in_platform_admin_client.get(url_for('main.add_data_retention', service_id=service_one['id']))
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert normalize_spaces(page.select_one('input')['value']) == "email"
assert page.find('input', attrs={'name': 'days_of_retention'})
def test_add_service_data_retention(
logged_in_platform_admin_client,
service_one,
mock_create_service_data_retention
):
response = logged_in_platform_admin_client.post(url_for('main.add_data_retention', service_id=service_one['id']),
data={'notification_type': "email",
'days_of_retention': 5
}
)
assert response.status_code == 302
settings_url = url_for(
'main.data_retention', service_id=service_one['id'], _external=True)
assert settings_url == response.location
assert mock_create_service_data_retention.called
def test_update_service_data_retention(
logged_in_platform_admin_client,
service_one,
fake_uuid,
mock_update_service_data_retention,
):
response = logged_in_platform_admin_client.post(url_for('main.edit_data_retention',
service_id=service_one['id'],
data_retention_id=fake_uuid),
data={'days_of_retention': 5}
)
assert response.status_code == 302
settings_url = url_for(
'main.data_retention', service_id=service_one['id'], _external=True)
assert settings_url == response.location
assert mock_update_service_data_retention.called

20
tests/conftest.py
View File

@@ -2672,8 +2672,26 @@ def normalize_spaces(input):
@pytest.fixture(scope='function')
def mock_get_service_data_retention(mocker):
data = {"id": str(fake_uuid),
"service_id": str(fake_uuid),
"service_name": "service name",
"notification_type": "email",
"days_of_retention": 5,
"created_at": datetime.now(),
"updated_at": None,
}
return mocker.patch('app.service_api_client.get_service_data_retention',
return_value={})
return_value=[data])
@pytest.fixture(scope='function')
def mock_create_service_data_retention(mocker):
return mocker.patch('app.service_api_client.create_service_data_retention')
@pytest.fixture(scope='function')
def mock_update_service_data_retention(mocker):
return mocker.patch('app.service_api_client.update_service_data_retention')
@pytest.fixture(scope='function')