More cleanup and changes for stable pr

app/assets/javascripts/listEntry.js

@@ -27,7 +27,7 @@
   };
   ListEntry.optionalAttributes = ['aria-describedby'];
   ListEntry.prototype.entryTemplate = Hogan.compile(
-    '<div class="list-entry margin-bottom-2">' +
+    '<div class="list-entry">' +
       '<label for="{{{id}}}" class="usa-label">' +
         '<span class="usa-sr-only">{{listItemName}} number </span>{{number}}.' +
       '</label>' +
@@ -39,14 +39,14 @@
         ' {{{sharedAttributes}}}' +
       '/>' +
       '{{#button}}' +
-        '<button type="button" class="usa-button--unstyled text-primary margin-top-1 input-list__button--remove">' +
+        '<button type="button" class="usa-button usa-button--secondary input-list__button--remove">' +
           'Remove<span class="usa-sr-only"> {{listItemName}} number {{number}}</span>' +
         '</button>' +
       '{{/button}}' +
     '</div>'
   );
   ListEntry.prototype.addButtonTemplate = Hogan.compile(
-    '<button type="button" class="usa-button usa-button--outline input-list__button--add margin-top-2">Add another {{listItemName}} ({{entriesLeft}} remaining)</button>'
+    '<button type="button" class="usa-button usa-button--outline input-list__button--add">Add another {{listItemName}} ({{entriesLeft}} remaining)</button>'
   );
   ListEntry.prototype.getSharedAttributes = function () {
     var $inputs = this.$wrapper.find('input'),
@@ -101,15 +101,8 @@
     if ($firstInput.length) {
       var classList = $firstInput.attr('class');
       if (classList) {
-        // Remove any GOV.UK or USA numbered classes, keep others
-        this.additionalClasses = classList
-          .split(' ')
-          .filter(function(cls) {
-            return cls &&
-                   !cls.match(/^(govuk-input|usa-input)/) &&
-                   cls !== 'usa-input--numbered';
-          })
-          .join(' ');
+        // Preserve any additional classes from the original input
+        this.additionalClasses = classList;
       } else {
         this.additionalClasses = '';
       }

app/assets/sass/uswds/_uswds-theme-custom-styles.scss

@@ -1093,7 +1093,13 @@ nav.nav {
   margin-top: 0;
 }
 
-// Global styling for radio button legends
-fieldset legend.usa-legend {
+// Radio button and checkbox legends
+.usa-radio legend.usa-legend,
+.usa-checkbox legend.usa-legend,
+.api-key-radios legend.usa-legend,
+.login-auth-radios legend.usa-legend,
+.auth-type-radios legend.usa-legend,
+.notification-type-radios legend.usa-legend,
+.organizations-radios legend.usa-legend {
   font-weight: 700;
 }

app/templates/components/select-input.html

@@ -12,12 +12,12 @@
 {% macro select_list(options, child_map, disable=[], option_hints={}, input="radio", indent_level=0) %}
     {% for option in options %}
       {% if child_map[option.data] %}
-        <div class="{% if indent_level > 0 %}margin-left-{{ indent_level * 4 }}{% endif %}">
+        <div class="{% if indent_level > 0 %}margin-left-{{ indent_level + 2 }}{% endif %}">
           {{ select_input(option, disable, option_hints, as_list_item=False, input=input) }}
         </div>
         {{ select_list(child_map[option.data], child_map, disable, option_hints, input=input, indent_level=indent_level + 1) }}
       {% else %}
-        <div class="{% if indent_level > 0 %}margin-left-{{ indent_level * 4 }}{% endif %}">
+        <div class="{% if indent_level > 0 %}margin-left-{{ indent_level + 2 }}{% endif %}">
           {{ select_input(option, disable, option_hints, as_list_item=False, input=input) }}
         </div>
       {% endif %}

app/templates/views/api/keys/create.html

@@ -20,8 +20,7 @@
 
   {% call form_wrapper() %}
     {{ form.key_name }}
-    <div class="margin-top-4 margin-bottom-3">
-      <div class="api-key-radios">
+    <div class="api-key-radios margin-top-5">
         {% if current_service.trial_mode %}
           {{ radios(
             form.key_type,
@@ -31,7 +30,6 @@
         {% else %}
           {{ radios(form.key_type) }}
         {% endif %}
-      </div>
     </div>
     {{ page_footer('Continue') }}
   {% endcall %}

app/templates/views/manage-users/permissions.html

@@ -11,7 +11,7 @@
 {% endif %}
 
 {% if service_has_email_auth %}
-  <div class="login-auth-radios margin-top-4">
+  <div class="login-auth-radios">
     {% if not mobile_number %}
       {{ radios(
         form.login_authentication,