Remove ‘(all networks)’ from settings label

I don’t think we need to say (all networks) in the header. The real
benefit of this change is forcing the platform admin person making the
change to explicitly give their choice of network.

And by not putting it in the label we don’t have future users from other
organisations wondering if there’s some option other than ‘all networks’
they need to think about.
This commit is contained in:
Chris Hill-Scott
2021-06-01 17:55:17 +01:00
parent c5196fbf07
commit bd19806ebf
3 changed files with 13 additions and 15 deletions

View File

@@ -23,9 +23,7 @@
{% else %}
<span class="navigation-service-type navigation-service-type--{{broadcast_channel}} {{margin_class}}">{{ broadcast_channel|title }}
{% endif %}
{% if allowed_broadcast_provider == "all" %}
(all networks)
{% else %}
{% if allowed_broadcast_provider != "all" %}
({{ allowed_broadcast_provider|format_mobile_network }})
{% endif %}
{% endif %}

View File

@@ -318,16 +318,16 @@ def test_some_broadcast_tour_pages_show_service_name(
'severe',
'all',
'.navigation-service-type.navigation-service-type--live',
'service one Live (all networks) Switch service',
'Live (all networks)',
'service one Live Switch service',
'Live',
),
(
False,
'test',
'all',
'.navigation-service-type.navigation-service-type--test',
'service one Test (all networks) Switch service',
'Test (all networks)',
'service one Test Switch service',
'Test',
),
(
False,
@@ -342,8 +342,8 @@ def test_some_broadcast_tour_pages_show_service_name(
'government',
'all',
'.navigation-service-type.navigation-service-type--government',
'service one Government (all networks) Switch service',
'Government (all networks)',
'service one Government Switch service',
'Government',
),
(
False,

View File

@@ -203,10 +203,10 @@ def test_platform_admin_sees_only_relevant_settings_for_broadcast_service(
(True, "training", "test", "all", "Training"),
(True, "live", "test", "ee", "Test (EE)"),
(True, "live", "test", "three", "Test (Three)"),
(True, "live", "test", "all", "Test (all networks)"),
(True, "live", "severe", "all", "Live (all networks)"),
(True, "live", "test", "all", "Test"),
(True, "live", "severe", "all", "Live"),
(True, "live", "severe", "three", "Live (Three)"),
(True, "live", "government", "all", "Government (all networks)"),
(True, "live", "government", "all", "Government"),
(True, "live", "government", "three", "Government (Three)"),
]
)
@@ -5802,13 +5802,13 @@ def test_post_service_set_broadcast_network_makes_you_choose(
'this service.',
]),
('live-test', [
'Test (all networks)',
'Test',
'Members of the public who have switched on the test '
'channel on their phones will receive alerts sent from '
'this service.',
]),
('live-severe', [
'Live (all networks)',
'Live',
'Members of the public will receive alerts sent from this '
'service.',
]),
@@ -5818,7 +5818,7 @@ def test_post_service_set_broadcast_network_makes_you_choose(
'service.',
]),
('live-government', [
'Government (all networks)',
'Government',
'Members of the public will receive alerts sent from this '
'service, even if theyve opted out.'
]),