darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-24 17:31:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

workaround in conftest for pytest.ini overriding all our env variables

Browse Source
This commit is contained in:
Kenneth Kehl
2024-04-29 11:06:25 -07:00
parent e50b4bb5f7
commit bc72288d4d
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
.github/workflows/checks.yml vendored
View File

@@ -132,11 +132,11 @@ jobs:
env:
API_HOST_NAME: https://notify-api-staging.app.cloud.gov/
# API_HOST_NAME: http://localhost:6011
DANGEROUS_SALT: ${{ secrets.DANGEROUS_SALT }}
SECRET_KEY: ${{ secrets.SECRET_KEY }}
ADMIN_CLIENT_SECRET: ${{ secrets.ADMIN_CLIENT_SECRET }}
ADMIN_CLIENT_USERNAME: notify-admin
NOTIFY_ENVIRONMENT: e2etest
E2E_DANGEROUS_SALT: ${{ secrets.DANGEROUS_SALT }}
E2E_SECRET_KEY: ${{ secrets.SECRET_KEY }}
E2E_ADMIN_CLIENT_SECRET: ${{ secrets.ADMIN_CLIENT_SECRET }}
E2E_ADMIN_CLIENT_USERNAME: notify-admin
E2E_NOTIFY_ENVIRONMENT: e2etest
NOTIFY_E2E_AUTH_STATE_PATH: ${{ secrets.NOTIFY_E2E_AUTH_STATE_PATH }}
NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }}
NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }}

8
tests/end_to_end/conftest.py
View File

@@ -89,7 +89,13 @@ def end_to_end_context(browser):
return context
def pytest_generate_tests(metafunc):
os.environ['DANGEROUS_SALT'] = 'blahblahdiddiblah'
os.environ['DANGEROUS_SALT'] = os.getenv('E2E_DANGEROUS_SALT')
os.environ['SECRET_KEY'] = os.getenv('E2E_SECRET_KEY')
os.environ['ADMIN_CLIENT_SECRET'] = os.getenv('E2E_ADMIN_CLIENT_SECRET')
os.environ['ADMIN_CLIENT_USERNAME'] = os.getenv('E2E_ADMIN_CLIENT_USERNAME')
os.environ['NOTIFY_ENVIRONMENT'] = os.getenv('E2E_NOTIFY_ENVIRONMENT')
@pytest.fixture()