mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-24 04:10:57 -05:00
Remove template from job page
Showing the template on the job page was semi-useful when you couldn’t see the contents of each individual message. It was still a bit weird because it just showed the template, never the actual messages that went out, with the placeholders. Now that users can click through to see individual messages, and can see a short preview of the content on each row I think we can safely lose the template preview on this page.
This commit is contained in:
@@ -114,21 +114,7 @@ def view_job(service_id, job_id):
|
||||
'views/jobs/job.html',
|
||||
finished=(total_notifications == processed_notifications),
|
||||
uploaded_file_name=job['original_file_name'],
|
||||
template=get_template(
|
||||
service_api_client.get_service_template(
|
||||
service_id=service_id,
|
||||
template_id=job['template'],
|
||||
version=job['template_version']
|
||||
)['data'],
|
||||
current_service,
|
||||
letter_preview_url=url_for(
|
||||
'.view_template_version_preview',
|
||||
service_id=service_id,
|
||||
template_id=job['template'],
|
||||
version=job['template_version'],
|
||||
filetype='png',
|
||||
),
|
||||
),
|
||||
template_id=job['template'],
|
||||
status=request.args.get('status', ''),
|
||||
updates_url=url_for(
|
||||
".view_job_updates",
|
||||
|
||||
@@ -32,7 +32,7 @@
|
||||
Notify delivers the message
|
||||
</p>
|
||||
{% if help == '3' %}
|
||||
<a href='{{ url_for(".go_to_dashboard_after_tour", service_id=current_service.id, example_template_id=template.id) }}'>
|
||||
<a href='{{ url_for(".go_to_dashboard_after_tour", service_id=current_service.id, example_template_id=template_id) }}'>
|
||||
Now go to your dashboard
|
||||
</a>
|
||||
{% endif %}
|
||||
|
||||
@@ -13,17 +13,8 @@
|
||||
{{ uploaded_file_name }}
|
||||
</h1>
|
||||
|
||||
{{ template|string }}
|
||||
|
||||
{{ ajax_block(partials, updates_url, 'status', finished=finished) }}
|
||||
{{ ajax_block(partials, updates_url, 'counts', finished=finished) }}
|
||||
{{ ajax_block(partials, updates_url, 'notifications', finished=finished) }}
|
||||
|
||||
{% if not help %}
|
||||
{{ page_footer(
|
||||
secondary_link=url_for('.view_template', service_id=current_service.id, template_id=template.id),
|
||||
secondary_link_text='Back to {}'.format(template.name)
|
||||
) }}
|
||||
{% endif %}
|
||||
|
||||
{% endblock %}
|
||||
|
||||
@@ -91,9 +91,6 @@ def test_should_show_page_for_one_job(
|
||||
assert response.status_code == 200
|
||||
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
|
||||
assert page.h1.text.strip() == 'thisisatest.csv'
|
||||
assert page.find('div', {'class': 'sms-message-wrapper'}).text.strip() == (
|
||||
'{}: Template <em>content</em> with & entity'.format(service_one['name'])
|
||||
)
|
||||
assert ' '.join(page.find('tbody').find('tr').text.split()) == (
|
||||
'07123456789 template content Delivered 1 January at 11:10am'
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user