Don’t let domains have none values

This commit is contained in:
Chris Hill-Scott
2019-02-12 10:33:02 +00:00
parent 0ce4dca799
commit ba8d2ff1e3
3 changed files with 7 additions and 11 deletions

View File

@@ -223,7 +223,7 @@ acas.org.uk:
owner: Advisory, Conciliation and Arbitration Service
crown: true
agreement_signed: false
charitycommission.gsi.gov.uk:
charitycommission.gsi.gov.uk: charitycommission.gov.uk
charitycommission.gov.uk:
owner: Charity Commission
crown: true
@@ -257,7 +257,7 @@ hse.gov.uk:
owner: Health and Safety Executive
crown: true
agreement_signed: false
hmtreasury.gsi.gov.uk:
hmtreasury.gsi.gov.uk: hmtreasury.gov.uk
hmtreasury.gov.uk:
owner: HM Treasury
crown: true
@@ -5122,7 +5122,7 @@ wyrebc.gov.uk:
owner: Wyre Borough Council
crown: false
agreement_signed: false
wyreforestdc.gov.uk:
wyreforestdc.gov.uk: wyreforest.gov.uk
wyreforest.gov.uk:
owner: Wyre Forest District Council
crown: false

View File

@@ -563,10 +563,10 @@ class AgreementInfo:
def _get_info(self):
details = self.domains.get(self._match)
details = self.domains.get(self._match, {})
if isinstance(details, None):
raise TypeError('Domain must have details ({})'.format(self._match))
if details is None:
raise TypeError('Domain must have details ({})'.format(self._domain))
if isinstance(details, str):
self.is_canonical = False

View File

@@ -403,11 +403,7 @@ def test_validate_government_domain_data():
True, False, None
}
assert (
agreement_info.owner is None
) or (
isinstance(agreement_info.owner, str)
)
assert isinstance(agreement_info.owner, str) and agreement_info.owner.strip()
assert agreement_info.agreement_signed in {
True, False, None