darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Restyle inbound text messages

Browse Source 
This commit adds a new kind of banner to the dashboard for summarising
things you might need to action.

This way we’ll be able to have multiple instances of this banner on the
same page without it looking too intense.

I never really liked the big blue banner for inbound text messages
because it became the most prominent thing on the page. It was an
interim solution that let us ship the feature until we had something
better.
This commit is contained in:
Chris Hill-Scott
2020-02-12 11:02:22 +00:00
parent 3eb550d297
commit b65b417a08
5 changed files with 64 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/app/main/views/test_dashboard.py
View File

@@ -222,11 +222,11 @@ def test_inbound_messages_shows_count_of_messages_when_there_are_messages(
'main.service_dashboard',
service_id=SERVICE_ONE_ID,
)
banner = page.select_one('a.banner-dashboard')
assert normalize_spaces(
page.select('.big-number-meta-wrapper')[0].text
) == '99 text messages received latest message just now'
assert page.select('.big-number-meta-wrapper a')[0]['href'] == url_for(
banner.text
) == '9,999 text messages received latest message just now'
assert banner['href'] == url_for(
'main.inbox', service_id=SERVICE_ONE_ID
)
@@ -248,9 +248,9 @@ def test_inbound_messages_shows_count_of_messages_when_there_are_no_messages(
'main.service_dashboard',
service_id=SERVICE_ONE_ID,
)
assert normalize_spaces(page.select('.big-number-meta-wrapper')[0].text) == '0 text messages received'
assert page.select('.big-number-meta-wrapper a')[0]['href'] == url_for(
banner = page.select_one('a.banner-dashboard')
assert normalize_spaces(banner.text) == '0 text messages received'
assert banner['href'] == url_for(
'main.inbox', service_id=SERVICE_ONE_ID
)