darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-04-25 03:30:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Bump all test dependencies

Browse Source 
This results in some new errors from flake8-bugbear:
```
B020: Loop control variable overrides iterable it iterates
```
I can't see an issue with the places that we do this, so have ignored
these warnings. If we keep getting these and they look fine, we can
create a global rule to ignore B020.
This commit is contained in:
Katie Smith
2022-04-06 11:35:14 +01:00
parent 0bec5e8f0a
commit b5fa270cd2
4 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/views/conversation.py
View File

@@ -100,7 +100,7 @@ def get_user_number(service_id, notification_id):
def get_sms_thread(service_id, user_number):
for notification in sorted((
for notification in sorted(( # noqa: B020
notification_api_client.get_notifications_for_service(service_id,
to=user_number,
template_type='sms')['notifications'] +

4
app/main/views/providers.py
View File

@@ -91,7 +91,7 @@ def edit_sms_provider_ratio():
def _get_versions_since_switchover(provider_id):
for version in sorted(
for version in sorted( # noqa: B020
provider_client.get_provider_versions(provider_id)['data'],
key=lambda version: version['updated_at'] or ''
):
@@ -109,7 +109,7 @@ def _chunk_versions_by_day(versions):
days = defaultdict(list)
for version in sorted(versions, key=lambda version: version['updated_at'] or '', reverse=True):
for version in sorted(versions, key=lambda version: version['updated_at'] or '', reverse=True): # noqa: B020
days[
format_date_numeric(version['updated_at'])
].append(version)